TextView failure

Question

I'm programming my first android app. I want to set text on a TextView. (I already searched here and found out, how to do it...But it still don't work)

Do you know, what the problem is?

This is my Java code.

package com.example.randomcraps;

import android.os.Bundle;
import android.app.Activity;
import android.view.Menu;
import android.widget.TextView;

import com.example.*;

public class MainActivity extends Activity {

    TextView text = (TextView) findViewById(R.layout.number);

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }


    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }

    public void getRandomNumber(){
        int i;
        double savePoint;
        savePoint = Math.random();
        savePoint = savePoint*100+1;
        i = (int)savePoint;
        text.setText(i);
    }

}

This is my XML Code

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:paddingBottom="@dimen/activity_vertical_margin"
    android:paddingLeft="@dimen/activity_horizontal_margin"
    android:paddingRight="@dimen/activity_horizontal_margin"
    android:paddingTop="@dimen/activity_vertical_margin"
    tools:context=".MainActivity" >

    <Button
        android:id="@+id/button1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentLeft="true"
        android:layout_alignParentRight="true"
        android:layout_alignParentTop="true"
        android:layout_marginTop="26dp"
        android:text="@string/Button1"
        android:onClick="getRandomNumber" />

    <TextView
        android:id="@+id/number"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_centerHorizontal="true"
        android:layout_centerVertical="true"
        android:text="@string/RandomNumber" />

</RelativeLayout>

Raghunandan · Accepted Answer · 2013-11-13T12:41:01.827

Change to

TextView text;
@Override
protected void onCreate(Bundle savedInstanceState) {
   super.onCreate(savedInstanceState);
   setContentView(R.layout.activity_main);
   text = (TextView) findViewById(R.id.number); // id of textview in activity_main.xml
 }

findViewById looks for a view with the id mentioned in the current inflated layout. So you need to set layout to the activity and then initialize your views.

Also change

text.setText(i); 
// looks for a resource with the id mentioned if not found you get ResourceNotFoundException

To

text.setText(String.valueOf(i)); 
// int i; i is an int value. Use String.valueOf(intvalue)

Edit:

Your method signature is different. It should be

public void getRandomNumber(View V){ // missing View as param
        ... //rest of the code
    }

Coz you have

android:onClick="getRandomNumber"

Quoting from docs

public static final int onClick

Name of the method in this View's context to invoke when the view is clicked. This name must correspond to a public method that takes exactly one parameter of type View. For instance, if you specify android:onClick="sayHello", you must declare a public void sayHello(View v) method of your context (typically, your Activity).

`findViewById()` won't find anything `R.layout`, should be `R.id`. Otherwise this is good advice. — laalto, Nov 13 '13 at 12:28
@laalto you are right just failed to spot it. will edit now. thanks — Raghunandan, Nov 13 '13 at 12:31

Devrim · Answer 2 · 2013-11-13T12:13:59.130

0

Change your code to this.

TextView text;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    text = (TextView) findViewById(R.id.number);
}

Also

text.setText(String.valueOf(i));

NOTE: findViewByID finds view from content. So basically you have to use that method after you set your content.

edited Nov 13 '13 at 12:13

answered Nov 12 '13 at 15:58

Devrim

15,345
4
66
74

I tried this right befor, but the the ID is still underlined. I don't know why, but "number" is still underlined. And it says: "Number is not resolved or is not a field. – Infinit666 Nov 13 '13 at 11:39
Have you declared a textView with id number at your activity_main? – Devrim Nov 13 '13 at 12:12
Ok I've edited my answer. Use R.id.number not R.layout.number. – Devrim Nov 13 '13 at 12:18
@Infinit666 you still have some mistakes in your code check my post – Raghunandan Nov 13 '13 at 12:41

score 0 · Answer 3 · answered Nov 13 '13 at 12:47

0

Set text color after setText and for guarantee set the font size. Sometimes it makes the color default white.

answered Nov 13 '13 at 12:47

e.ozmen

269
3
17

TextView failure

3 Answers3