I have issue in onclick and href in tag

Question

I have link as follows:

<a onclick=delete() href=".$this->action('delete', $data['status_id']).">Delete</a>

the javascript code as follows:

function delete() {
    if (confirm('<?php echo $delConfirmJS ?>')){
         return true;
    }
}

the confirmation message shown, if i cancel message the href link target executes. How to stay it if user cancel confirmation means?

@alKid More over same but, they using jquery In this problem he asked for pure javascript. — CJ Ramki, Nov 15 '13 at 11:36

score 4 · Answer 1 · answered Nov 15 '13 at 11:19

you have to return the result in onclick (and use quotes!)

<a onclick="return delete()" 
   href=".$this->action('delete', $data['status_id']).">Delete</a>

and remember to return false if the user does not confirm, this is a small change:

function delete() {
    return confirm('<?php echo $delConfirmJS ?>');
}

score 2 · Answer 2 · answered Nov 15 '13 at 11:18

2

function delete() {

return confirm("<?php echo $delConfirmJS ?>");

}

If user will press a cancel button confirm will return false. In DOM event handlers return false is the same than prevent default(browser) behavior.

answered Nov 15 '13 at 11:18

Alex

11,115
12
51
64

no its execute ... not working – Kumar Shanmugam Nov 15 '13 at 11:20
2

add return in onclick attribute ` – Alex Nov 15 '13 at 11:23

score 2 · Answer 3 · answered Nov 15 '13 at 11:19

2

You need to reverse your logic to prevent the click, rather than allow it:

function delete() {
    if (!confirm('<?php echo $delConfirmJS ?>')){
         return false;
    }
}

answered Nov 15 '13 at 11:19

Rory McCrossan

331,213
40
305
339

I think my question not clear to you, even my ok or cancle the confirmation its execute... anyway thanks i got it... – Kumar Shanmugam Nov 15 '13 at 11:33

score 0 · Answer 4 · answered Nov 15 '13 at 11:19

Try with:

function delete(e) {
    if (confirm('<?php echo $delConfirmJS ?>')){
         return true;
    }
    e.stopPropagation();
    return false;
}

P.S. and please put your attributes values in quotes, i.e. onclick=delete() should be onclick="delete()".

I have issue in onclick and href in tag

4 Answers4