C# Create txt file and save

Question

I am trying to create a file and save text, but it's only creating file can anyone suggest what the problem is?

private void button2_Click(object sender, EventArgs e)
    {
        SaveFileDialog sfd = new SaveFileDialog();
        sfd.Filter = "Text File|*.txt";
        sfd.FileName = "Password";
        sfd.Title = "Save Text File";
        if (sfd.ShowDialog() == System.Windows.Forms.DialogResult.OK)
        {
            string path = sfd.FileName;
            StreamWriter bw = new StreamWriter(File.Create(path));
            bw.Write(randomstring);
            bw.Dispose();
        }
    }

Are you trying to create a file or append to file if one already exists ? — Habib, Nov 20 '13 at 18:36
Grant, randomstring first i show it in label.text then i trying to save. — Mik, Nov 22 '13 at 07:28

score 3 · Answer 1 · answered Nov 20 '13 at 18:37

3

You need to call bw.Close() before calling bw.Dispose(). Per the API: "You must call Close to ensure that all data is correctly written out to the underlying stream." (http://msdn.microsoft.com/en-us/library/system.io.streamwriter.close(v=vs.110).aspx)

I'd actually change the code to:

using (StreamWriter bw = new StreamWriter(File.Create(path)))
{
    bw.Write(randomstring);
    bw.Close();
}

The using block will automatically call Dispose(), whether or not everything completes successfully.

answered Nov 20 '13 at 18:37

musical_coder

3,886
3
15
18

I don't see any reason to call close since Dispose is equal to close – Sriram Sakthivel Nov 20 '13 at 18:49
@SriramSakthivel it is? – David Pilkington Nov 20 '13 at 19:03
Reflector is your friend :) – Sriram Sakthivel Nov 20 '13 at 19:08
@SriramSakthivel: they're not the same according to that API link I posted. – musical_coder Nov 20 '13 at 19:26
That link doesn't state both are different anywhere. FYI take a look at [this](http://stackoverflow.com/a/1187728/2530848) – Sriram Sakthivel Nov 20 '13 at 19:30

David Pilkington · Answer 2 · 2013-11-20T18:47:40.487

2

Try and use File.WriteAllText instead

    if (sfd.ShowDialog() == System.Windows.Forms.DialogResult.OK)
    {
        //...
        File.WriteAllText(path, randomstring);
    }

edited Nov 20 '13 at 18:47

answered Nov 20 '13 at 18:36

David Pilkington

13,528
3
41
73

score 1 · Answer 3 · answered Nov 20 '13 at 18:37

1

bw.Write(randomstring);
bw.Dispose();

You write something, then dispose of the object entirely. Try:

bw.Write(randomstring);
bw.Close();
bw.Dispose();

answered Nov 20 '13 at 18:37

user3012708

793
1
11
33

score 0 · Answer 4 · answered Nov 20 '13 at 18:40

Per the documentation, you need to call bw.Close() before you dispose of it. Also, you should use using to ensure that all IDisposables are properly disposed of.

if (sfd.ShowDialog() == System.Windows.Forms.DialogResult.OK)
{
    string path = sfd.FileName;
    using (var fs = File.Create(path))
    using (StreamWriter bw = new StreamWriter(fs))
    {
        bw.Write(randomstring);
        bw.Close();
    }
}

Or just use File.WriteAllText:

if (sfd.ShowDialog() == System.Windows.Forms.DialogResult.OK)
{
    string path = sfd.FileName;
    File.WriteAllText(path, randomstring);
}

C# Create txt file and save

4 Answers4