Custom php function dropdown list from mysql table

Question

PHP noob with a challenge.

I have a custom php function:

function country_dropDown(){
    $dropDown = mysql_query("SELECT * FROM countries");
        while ($record = mysql_fetch_array($dropDown)) {
            echo '<option value="' . $record['id'] . '">' . $record['name'] . '</option>';
        }
}

'countries' table has 2 fields = id, name.

There are over 200 rows in this 'countries' table.

I can call this function in a html form that requires user input to select from the list of available countries from the list like this.

<select name="classID"><?php country_dropDown() ?></select>

I have some questions I hope someone can help me with.

1. When I call this function inside a html form and look at the source code I can see all 249 countries as "select options". Is there a best practice or efficient method so it does not list all countries in the source code?

2. The drop down list always displays, "Afganistan" which is the first row in the 'countries' table. How can I modify my custom function so it does not show any value or display the text, "Select Country"?

3. I have another table called 'student' with 2 fields: studentName, countriesID. I have a html form that lets me edit a student's record. It populates the default value of the student's name into the input text field but how do I make the dropdown function 'selected' the student's 'countryID' from the row? It always shows, "Afganistan".

4. Is there a best practice method or more efficient way to approach this countries dropdown select rather than my custom function?

I'm grateful for any assistance.

Answer 1

1) No, not really - If it isn't in the source code then it won't get rendered in the page.

2 & 3) You can just add a 'Please select one' option before your countries. You need a variable that has the current 'countId' and test against it. If it is the same as the current one in the loop, add a selected attribute to that option:

$countryID = 32; //This will be pulled from the student's record prior to this code.
echo '<option value=0>Please select one</option>';
while ($record = mysql_fetch_array($dropDown)) {
    echo '<option value="' . $record['id'] . '" '.($countryID == $record['id'] ? 'selected' : '').'>' . $record['name'] . '</option>';
}

4) Not really. Apart from maybe using a database library that isn't deprecated.

Answer 2

Best practice #1:

<select name="classID">
    <option value="invalid">--- select a country:</option>
    <?php country_dropDown() ?></select>

Best practice #2:

...
echo '<option ' . 
         ($record['id']==$studentsLangId?' selected="selected" ':'' ) . 
      ' value="'.  $record['id'] . '">' . $record['name'] . '</option>';

Answer 3

1. I don't know whether I understand what you mean. If you want to access to the full list inside a select tag, it will always be displayed in the source code.

2. Just add a new option element at the top of your list. For example:

   <select name="classID"> <option value="0">none</option> <?php country_dropDown() ?> </select>

3. You have to get the id of the country associate to the user and use the "selected" attribute inside the option element when both id fields matched.

4. Definitely. You MUST use PDO as mysql_query function has been declared obsolete and don't use * to fetch all the fields, write their names instead.

Answer 4

1. No

2. For displaying "Select Country" rather than your first row in db you can do it in 3 ways:

   2.a: write echo '<option value=0>Please Select Country</option>' before your while loop  
   
   2.b: make one entry in database (which should be the first row) as **"Select Country"**  
   
   2.c: <select name="classID"><option value=0>Please Select Country</option><?php country_dropDown() ?></select>  
   

3. What have you tried for this?

4. Not exactly.

Answer 5

1. No

2. Just create an empty select tag before your "While"

   <option value="">Select</option>

3. You should include an if operator in the while method, so if the user's country equals the current country in the while loop, then add an extra selected="selected" inside your "" tag.

4. This is the way I do it too