Why does my JOptionPane repeatedly prompt for Major Sheet status from my code below

Question

I'm having an infinite while loop issue, no matter what I type in even if it is "Filed" or "Incomplete" the loop keeps re prompting and I can't figure out why.

strMajorSheet = JOptionPane.showInputDialog(null,"What is the advisee's major sheet status? (Filed/Incomplete)",
                "Advisee's Major Sheet",3);

if(strMajorSheet == "Filed" || strMajorSheet == "Incomplete")
                    {

                        switch(strMajorSheet)
                        {
                            case "Filed":
                                blnMajorSheet = true;
                            case "Incomplete":
                                blnMajorSheet = false;


                        }
                    }
                    else
                    {
                        while(strMajorSheet != "Filed" && strMajorSheet != "Incomplete")
                        {
                            strMajorSheet = JOptionPane.showInputDialog(null,"What is the advisee's major sheet status? (Filed/Incomplete)",
                                "Advisee's Major Sheet",3);


                        }

Why the `if` statement AND `case` statement? You could do the whole thing with the `case` statement... — MadProgrammer, Dec 04 '13 at 00:57

score 0 · Answer 1 · answered Dec 04 '13 at 00:57

0

String comparison Java must be done using equals and equalsIgnoreCase

answered Dec 04 '13 at 00:57

score 0 · Accepted Answer · answered Dec 04 '13 at 00:59

0

please don't compare String using ==

change it to

if(strMajorSheet.equals("Filed") || strMajorSheet.equals("Incomplete"))
......

while(!strMajorSheet.equals("Filed") && !strMajorSheet.equals("Incomplete"))
......

answered Dec 04 '13 at 00:59

Baby

5,062
3
30
52

Oh my goodness I completely goofed. I'm still a beginner when it comes to programming, much thanks. – user2864535 Dec 04 '13 at 01:04

score 0 · Answer 3 · answered Dec 04 '13 at 01:02

First of all, String comparison is not done using ==, which compares the object references, which are unlikely to be true very often. Instead, you need to use equals or equalsIgnoreCase to compare the contents of the two Strings.

Having said that, I don't know why you're bothering with the if statement as the entire logic can be achieved using just the switch statement, for example...

boolean gotInput = true;

do {
    String strMajorSheet = JOptionPane.showInputDialog(null, "What is the advisee's major sheet status? (Filed/Incomplete)",
                    "Advisee's Major Sheet", 3);

    gotInput = true;
    switch (strMajorSheet) {
        case "Filed":
            blnMajorSheet = true;
            break;
        case "Incomplete":
            blnMajorSheet = false;
            break;
        default:
            gotInput = false;
    }
} while (!gotInput);

Now, beware, that switch (String) is the same as using String#equals, that is, it's case sensitive comparison.

Why does my JOptionPane repeatedly prompt for Major Sheet status from my code below

3 Answers3