For loop: my for loop is not executing properly

Question

I'm having trouble getting a for loop in my program to wrok. I'm not sure what I'm doing wrong. I've been working on it for about 3 hours and still have no clue what to do.

I fixed the while statement. That is not the problem. The problem is with the for loop towards the bottom of the code.

Here is my code:

    while(!(strSelection=("5")))
    {
        strSelection=JOptionPane.showInputDialog(
                                                    null, "~~Please make a selection from the menu below~~"+
                                                    "\n\n1. Add a new advisee"+
                                                    "\n2. Update and advisee's information"+
                                                    "\n3. Display all advisees"+
                                                    "\n4. Display advisees who are cleared to graduate"+
                                                    "\n5. Exit"+
                                                    "\n\nWhat is your selection?", "Menu", 3);

        switch(strSelection)
        {
            case "1":

                String strString;
                String strHours;
                int iHours;
                String strMajor;
                boolean blnMajor;
                String strIntent;
                boolean blnIntent;

                adv[iCount]=new Advisee();
                adv[iCount].setName(JOptionPane.showInputDialog(null,"What is the advisee's name?","Name",3));
                adv[iCount].setID(JOptionPane.showInputDialog(null,"What is the advisee's ID?","ID",3));
                adv[iCount].setConcentration(JOptionPane.showInputDialog(null,"What is the advisee's concentration?","Concentration",3));
                adv[iCount].setAdvisor(strAdvisor);
                strHours=JOptionPane.showInputDialog(null,"What are the advisee's completed hours?","Completed Hours",3);
                iHours=Integer.parseInt(strHours);
                adv[iCount].setHoursCompleted(iHours);
                strMajor=JOptionPane.showInputDialog(null,"Does the advisee have the major sheet?","Major Sheet",3);
                blnMajor=Boolean.parseBoolean(strMajor);
                adv[iCount].setMajorSheet(blnMajor);
                strIntent=JOptionPane.showInputDialog(null,"Does the advisee have the intent to graduate form filed?","Intent To Graduate",3);
                blnIntent=Boolean.parseBoolean(strIntent);
                adv[iCount].setIntentFiled(blnIntent);
                iCount++;
                iAccum++;
                break;

            case "2":
                String strUpdateSelection;
                String strOutput="";
                String strAccumulator="";
                System.out.print(iAccum);
                for(iCount=0;iCount==iAccum;iCount++)
                {
                    strOutput=adv[iCount].getName();
                    strAccumulator+=strOutput;
                }

                strUpdateSelection=JOptionPane.showInputDialog(
                                                                null,"~~Please select which advisee's information you need to update~~"+
                                                                "\n"+strOutput+
                                                                "\nWhat is your selection?","Information Update",3);

                break;
            case "5":
                System.exit(0);
                break;
        }

    }                                           
}
}

A tip would be to only post the code that is giving errors intead of everything. And be concrete about your error :) — Dylan Meeus, Dec 04 '13 at 08:13
I need it to go through the loop and display all of the advisee's the user inputs. — Treyeyeeyeeye, Dec 04 '13 at 08:15
This is for a project that is due tomorrow at 9 am. I've been up all night doing it. I didn't knew where else to turn but this site. — Treyeyeeyeeye, Dec 04 '13 at 08:21
I looked at that link and I don't understand how it pertains to my problem. — Treyeyeeyeeye, Dec 04 '13 at 08:26
@Treyeyeeyeeye To put it plainly, `while (strSelection != "5")` doesn't do what you think it does. — Dennis Meng, Dec 04 '13 at 08:35

score 0 · Answer 1 · answered Dec 04 '13 at 08:13

0

Change from

while(strSelection!="5")

To

while(!"5".equals(strSelection))

answered Dec 04 '13 at 08:13

Masudul

21,823
5
43
58

Some explanation would be nice. – ApproachingDarknessFish Dec 04 '13 at 08:26
@ValekHalfHeart In most cases you won't call "==" operator to compare Strings, see here http://stackoverflow.com/questions/767372/java-string-equals-versus – gyorgyabraham Dec 04 '13 at 09:46

score 0 · Answer 2 · answered Dec 04 '13 at 08:13

0

while(!strSelection.equals("5"))

answered Dec 04 '13 at 08:13

neutrino

2,297
4
20
28

Some explanation would be nice. – ApproachingDarknessFish Dec 04 '13 at 08:25

Ruchira Gayan Ranaweera · Answer 3 · 2013-12-04T08:38:53.250

0

You are comparing not-equality of a String. The way you should do is following

 while(!"5".equals(strSelection))

Or

 while(!strSelection.equals("5"))

Not

 while(strSelection!="5")

And change your for loop

 for(iCount=0;iCount<=iAccum;iCount++)

instead of

 for(iCount=0;iCount==iAccum;iCount++)

edited Dec 04 '13 at 08:38

answered Dec 04 '13 at 08:31

Ruchira Gayan Ranaweera

34,993
17
75
115

i understand. I fixed that problem in my code. The problem that i'm having now is with the for loop. – Treyeyeeyeeye Dec 04 '13 at 08:36
@Treyeyeeyeeye correct your `for` loop as my answer – Ruchira Gayan Ranaweera Dec 04 '13 at 08:39
I made that change and now it is giving me a null pointer exception error upon compiling. – Treyeyeeyeeye Dec 04 '13 at 08:44
@Treyeyeeyeeye you should figure out what is that issue. There is no way to have null pointer in compile time. Null pointer will throw in run time – Ruchira Gayan Ranaweera Dec 04 '13 at 08:46
sorry. correction. it was in run time. – Treyeyeeyeeye Dec 04 '13 at 08:46
I'm not sure why i'm getting it. I've looked up what a null pointer exception error means. i'm just not sure how to apply it to this problem. – Treyeyeeyeeye Dec 04 '13 at 08:47
@Treyeyeeyeeye try with `debug`. Then you will realize. – Ruchira Gayan Ranaweera Dec 04 '13 at 08:51
"try with debug" ? What does that mean. I've never heard of that. I know i probably sound stupid right now but... – Treyeyeeyeeye Dec 04 '13 at 08:53
@Treyeyeeyeeye are you using IDE(Ecplise, NEtbeans, Intellij IDEA) for coding. you should. Then you can use debug feature. – Ruchira Gayan Ranaweera Dec 04 '13 at 08:54
I'm using notepad++. My class requires me to use that program. – Treyeyeeyeeye Dec 04 '13 at 08:55
@Treyeyeeyeeye it is just a text editor. You can't use such a basic editor to do coding. you should use a IDE – Ruchira Gayan Ranaweera Dec 04 '13 at 08:57
I have eclipse. How would i use the debugger> – Treyeyeeyeeye Dec 04 '13 at 08:58
@Treyeyeeyeeye just follow some stuff in google related to coding in Eclips – Ruchira Gayan Ranaweera Dec 04 '13 at 09:01

For loop: my for loop is not executing properly

3 Answers3