Finding user object in view? Ruby on Rails

Question

    <% @review.each do |review|%>
    <% if review.host_id == @host.id> 
       <%= @user = User.find(review.user_id) %>
    <% end %>
<% end %>

So I'm a bit confused. I have a few things going on here. I'm doing a loop through all reviews of hosts and then checking if the stored host.id value is equal to the active @host object's id that is passed from the controller. Problem is.. Now I need get the user object from the user ID stored in the review but, I'm unsure exactly how to do it. I can't do it from the controller as all this is done in the loop. As you can see I tried to do it with the code above but, I highly doubt I did it right. Please help me out on this. Thanks.

I'm sorry Monk Code I'm honestly still quite new to Rails but yeah, I didn't think it was. What would you recommend? And Thaha kp review.user does not hold the user object it holds the ID. — Riding Rails, Dec 05 '13 at 11:22
Again: why can't you do it in the controller? Can't you make loop there? Also you probably prefer to use `@user = User.find(@review.find{|r| r.host == @host}.id)` — BroiSatse, Dec 05 '13 at 11:24
@user3068704 not worry about it but remember. Happy coding!!! — Roman Kiselenko, Dec 05 '13 at 11:35

score 1 · Accepted Answer · edited May 23 '17 at 12:21

1

You should pre-load users with loading reviews, in controller. First, you should have belongs_to association, like this:

class Review < ActiveRecord::Base
  belongs_to :user
  # ...
end

then, in controller, you could use includes, this way:

@reviews = Review.includes(:user)

Now, for every review record in @reviews relation, to get associated user you can call user method, like this:

review.user

What's more, (and that's advantage of using includes) it doesn't fire new SQL query for every single review, so you avoid quite common N + 1 problem.

edited May 23 '17 at 12:21

Community

1
1

answered Dec 05 '13 at 11:25

Marek Lipka

50,622
7
87
91

Thank you. I never knew this is what you could do with associations. Still fairly new. – Riding Rails Dec 05 '13 at 11:42

score 0 · Answer 2 · answered Dec 05 '13 at 11:23

0

You can make a relationship in

class Review < ActiveRecord::Base
belongs_to :user
end

and then in view

review.user #gives you user

answered Dec 05 '13 at 11:23

techvineet

5,041
2
30
28

score 0 · Answer 3 · answered Dec 05 '13 at 11:27

Put association in Review Model

class Review < ActiveRecord::Base

.
.
.
  belongs_to :user
.
.
.

end

After putting association you can directly call association to find user object using Review object.

review.user

But this will raise N+1 query problem, so better user include user while finding review, It will execute only two queries one for finding reviews and another for finding users.

@reviews = Review.includes(:user)

Finding user object in view? Ruby on Rails

3 Answers3