Android - Listview gets messy when scrolling. Related to ListView recycling

Question

I have a list view where the two names are displayed based on some conditions. Sometimes the first name alone is displayed and sometimes the first name and the second name is displayed in the view(each row) of the list view. All is fine when the list appears initially. But when I scroll through the list, the issue happens.

Row 0 goes messy in the list view. It displays the second name though I have programmed it to be invisible.The same happens to other rows when I scroll further down and come back.

I got to know this is due to list recycling. But I have implemented the code mentioned to avert this situation. But this still keep happening. Can you help me in overcoming this please.

The code snippet is below. Thanks for your time.

@Override
public View getView(final int position, View convertView, ViewGroup parent) {

    View view = convertView;
    ViewHolder holder;
    if (view == null) {
        LayoutInflater inflater = (LayoutInflater) activity
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        view = inflater.inflate(row, null);

        holder = new ViewHolder();
        view.setTag(holder);
    } else {
        holder = (ViewHolder) view.getTag();
    }

    if ((items == null) || ((position + 1) > items.size()))
        return view;

    objBean = items.get(position);

    holder.firstcontactname = (TextView) view.findViewById(R.id.firstcontactname);
    holder.secondcontactname = (TextView) view.findViewById(R.id.secondcontactname);

    }


if (holder.firstcontactname != null && null != objBean.getfirstcontactname()
            && objBean.getfirstcontactname().trim().length() > 0) {
        //holder.firstcontactname.setText(Html.fromHtml("" + "<b>"+"<font color='black'>"+objBean.getfirstcontactname()));
        holder.firstcontactname.setText(Html.fromHtml("" + "<b>"+objBean.getfirstcontactname()));
    }

    if (holder.secondcontactname != null && null != objBean.getsecondcontactname()
            && objBean.getsecondcontactname().trim().length() > 0) {
        //holder.secondcontactname.setText(Html.fromHtml("" + "<b>"+"<font color='black'>"+objBean.getsecondcontactname()));
        holder.secondcontactname.setText(Html.fromHtml("" + "<b>"+objBean.getsecondcontactname()));
    }

    if (objBean.getsecondcontactname()==null ) {
        holder.secondcontactname.setVisibility(View.INVISIBLE);
    } 


return view;
    }

[I had written a blog for maintaining the view with data while ListView scrolling, just have a go at it](http://stackoverflow.com/a/10896140/726863) — Lalit Poptani, Dec 11 '13 at 06:51

score 1 · Answer 1 · answered Dec 10 '13 at 22:16

First off, you should find the TextViews

holder.firstcontactname = (TextView) view.findViewById(R.id.firstcontactname);

inside the if(view == null) block right after you instantiate your new Holder().

Second, because of view recycling you need to take care of every 'else' case. Right now you are checking if holder.firstcontactname is not null then setting the text, if it IS null (the 'else' case) you need to set the text to empty or hide the text field otherwise the text will still be there from the old view that was inflated in a previous row.

I moved the code holder.firstcontactname = (TextView) view.findViewById(R.id.firstcontactname); and holder.secondcontactname = (TextView) view.findViewById(R.id.secondcontactname); next to the holder = new ViewHolder(); line. I am working on the second point. Will update you. Thanks — Timothy Rajan, Dec 10 '13 at 22:34

nitesh goel · Answer 2 · 2013-12-11T06:44:12.750

1

this is not your questions answere.but instead of using this line:

 if ((items == null) || ((position + 1) > items.size()))
    return view;

override this method

@Override public int getCount() { return items.size(); }

now if there is something in items list then only getview will get called.

now for your question's answer i would say if you want a simple solution : inflate a new view every item, don not check for (view==null) and you can remove the holder pattern as well. keep it simple. i know it is not efficient way but if your list Item view is simple and in scrolling its fine with you then only use it. else you need to do a little more work to make it smooth. let me know if this not work for you.

edited Dec 11 '13 at 06:44

answered Dec 11 '13 at 06:22

nitesh goel

6,338
2
29
38

Hi Nitesh. Thanks for this. My listview is quite complex. I tried all possibilities but still the issue persists – Timothy Rajan Dec 11 '13 at 07:04
sorry but as i can see your list view does not seems to me complex .first please try to implement what i suggested that should work . if you face issue with scrolling then i will give you other solution. – nitesh goel Dec 11 '13 at 07:13
Hi Nitish Thanks for this. In actual my listview has 7 components which gets populated. For easy understanding I constructed the question with two components. All are labels and I need to make these labels visible or GONE based on the input. The moment list is constructed everything is fine. But while scrolling everything turns uglier. – Timothy Rajan Dec 11 '13 at 07:16
can you post your whole adapter and xml so that i can give a complete solution. – nitesh goel Dec 11 '13 at 07:38
Can I mail it to you. I have sent you a linkedin request. I will repost the solution fitting this question back in SO. – Timothy Rajan Dec 11 '13 at 07:46

Android - Listview gets messy when scrolling. Related to ListView recycling

2 Answers2