i can't use properly If else here

Question

I've provided a little snippet that represents this issue below.

var app = angular.module("app", []);

app.controller("AppCtrl", function ($http, $scope) {
  $scope.fetchData = function () {
    document.getElementById("displayBlock").className='hidden';
    document.getElementById("throbber").className='throbber';
    document.getElementById("intermediate").className='unhidden';
    document.getElementById("header").className='step';
    var app = this;
    var p= $scope.formUsernameTex;
    alert(p);
    if(p!="undifined"){
      $http.get("https://api.github.com/users/"+$scope.formUsernameText)
        .success(function (data) {
          app.user = data;

          $scope.name=app.user.name;
          $scope.avatar_url=app.user.avatar_url;
          if (app.user.html_url==null) {$scope.html_url="Not Shared";} else {$scope.html_url=app.user.html_url};
          if (app.user.company==null||app.user.company=="") {$scope.company="Not Shared";} else {$scope.company=app.user.company};
          if (app.user.blog==null) {$scope.website="Not Shared";$scope.websiteLink="";} else {$scope.website=app.user.blog;$scope.websiteLink=$scope.website;};
          if (app.user.location==null) {$scope.location="Not Shared";} else {$scope.location=app.user.location;};
          if (app.user.email==null) {$scope.email="Not Shared";$scope.emailLink="";} else {$scope.email=app.user.email;$scope.emailLink="mailto:"+$scope.email;};
          if (app.user.hireable) {var hireStatus="Yes"} else {var hireStatus="No"};
          $scope.hireable=hireStatus;
          $scope.public_repos=app.user.public_repos;
          $scope.public_gists=app.user.public_gists;
          $scope.followers=app.user.followers;
          $scope.following=app.user.following;
          var date = new Date(app.user.created_at);
          $scope.created_at=date.getDate()+"/"+date.getMonth()+"/"+date.getFullYear();

          //Display Block Functions
          document.getElementById("throbber").className='hidden';
          document.getElementById("displayBlock").className='unhidden';
          document.getElementById("header").className='';
        })
        .error(function () {
          document.getElementById("intermediate").className='hidden';
          document.getElementById("header").className='initial';
          alert("Hmm.... That doesn't look quite right!\n\nOctoStats couldn't find the User's data on GitHub! :-/")
        })
    }
    else {alert("Add name properly");}
  }

})

Suppose here p=undifined I want to give one alert just and rest of the function will not be worked that time.

Please show me how to do it.

Here I can't use if else properly

you don't need about 90% of the code shown when working with angular — charlietfl, Dec 15 '13 at 02:28
What do you see when the first `alert` runs? The one from: `var p= $scope.formUsernameTex; alert(p);` — Alex Moore, Dec 15 '13 at 02:36

score 0 · Answer 1 · edited May 23 '17 at 12:28

The short answer to your question is to change your if statement to this:

if(p != undefined)

where you fix the spelling of "undefined", and also remove the quotes.

The longer answer, like charlietti says, is to really get the hang of the basics of angular before diving into a heavier app. Off the bat, I see a few things that won't make it into your final version:

You'll never (well... super-rarely) use getElementById() in a final angular app. Instead, you'll update your model through your $scope, and let angular change your UI for you. For starters, check out ngShow, ngHide, and ngClass to see how this can be done.
Instead of copying all your app.user properties onto $scope, you would just set $scope.app.user = app.user and let the rest of it work.

I would recommend you check out this SO post to get a better understanding too.

Alex Moore · Answer 2 · 2013-12-16T15:11:11.097

I think you may have several typos in either your source code, or your transcription to Stack Overflow.

You are missing a t at the end of $scope.formUsernameTex, you've misspelled undefined, and you don't need to put double quotes around undefined in the following lines:

var p= $scope.formUsernameTex;
alert(p);
if(p!="undifined"){
    $http.get("https://api.github.com/users/"+$scope.formUsernameText)

It should probably be:

var p = $scope.formUsernameText;
alert(p);
if(p != undefined){
    $http.get("https://api.github.com/users/"+$scope.formUsernameText)

i can't use properly If else here

2 Answers2