Using a method as a function in a JSF page

Question

Below you can see a method that return an IP address.

I'd like to use it in a JSF page. How can I achieve this?

public static String getClientIpAddr(HttpServletRequest request) {  
  HttpServletRequest request = (HttpServletRequest)    FacesContext.getCurrentInstance().getExternalContext().getRequest();
  String ipAddress = request.getHeader("X-FORWARDED-FOR");
  if (ipAddress == null) {
      ipAddress = request.getRemoteAddr();
  }
  return ipAddress;
}

There is no best way. Me: I'd just return it through a JSF managed bean property that calls the utility function. — Gimby, Dec 16 '13 at 12:18
It's a pretty simple program. Actually, it is a contact form. I'd like to catch IP address to show it and write on database together the others fields. — Marcos, Dec 16 '13 at 12:38
What the `HttpServletRequest request` parameter is supposed to do in your method? — Aritz, Dec 16 '13 at 14:43
possible duplicate of [How to create a custom EL function?](http://stackoverflow.com/questions/7079978/how-to-create-a-custom-el-function) — BalusC, Dec 16 '13 at 15:47
By the way, the `X-Forwarded-For` header contains multiple IP addresses commaseparated ... If you're using OmniFaces, better use `Faces#getRemoteAddr()`. That `HttpServletRequest` argument which you never use locally (and is causing uncompilable code) is also weird. — BalusC, Dec 16 '13 at 15:49

score 1 · Answer 1 · answered Dec 16 '13 at 13:56

1

Your java function have doublicate variable names. Look at the function parameter (request) and at the local variable name request.

Remove the function parameter, cos you get it from facesContext.

you can access the result by a direct function call from the view like :

<h:outputText value="#{myBean.getClientIpAddr()}" />

answered Dec 16 '13 at 13:56

Sence

115
8

1

Note that you'd need to make `getClientIpAddr` non-static for this to work. – mabi Dec 16 '13 at 14:08

score 1 · Accepted Answer · answered Dec 16 '13 at 15:45

1

If all you have to do is work with request to show the IP in the view, you don't even need to call a method from a managed bean, you can do it directly in your Facelet:

<p>
    IP of request: #{empty header['X-FORWARDED-FOR'] ? request.remoteAddr : header['X-FORWARDED-FOR']}
</p>

answered Dec 16 '13 at 15:45

Luiggi Mendoza

85,076
16
154
332

nice solution. clean, elegante and it works. thanks. – Marcos Dec 16 '13 at 23:17

skybber · Answer 3 · 2013-12-17T19:37:33.273

-1

What about this: "#{request.getHeader('X-FORWARDED-FOR') != null ? request.getHeader('X-FORWARDED-FOR') : request.remoteAddr}"

edited Dec 17 '13 at 19:37

answered Dec 16 '13 at 13:35

skybber

409
4
13

You're missing the else part of the ternary. – mabi Dec 16 '13 at 14:07
Then you'll obtain the complete header? – Aritz Dec 16 '13 at 14:48

Using a method as a function in a JSF page

3 Answers3