Java try catch returning false variable

Question

When I enter my value for the String 'decision' as 'Yes' the if statement then acts as if the value of decision is anything but 'Yes' by executing the line System.out.println("Please continue shopping"); What can I do to fix this? Here is the class the problem is in:

 //paying for this instance of a basket
public void payBasket(double cash){
    String decision;
    double balance;
    System.out.println("You have £" +cash);
    decision = null;
    if(cash > endTotal)
    {System.out.println("You have enough money to pay for this basket");
    }
    else 
    {System.out.println("You need more money before you can pay for these items");};
    BufferedReader reader;
    reader = new BufferedReader(new InputStreamReader(System.in));
    System.out.println("Would you like to pay for this basket?");
    try{
     decision = reader.readLine();
    }
    catch (IOException ioe){
        System.out.println("an unecpected error");
    }

    if(decision == "Yes"){balance = endTotal - cash;
        System.out.println("Your current balance is " + balance);}
        else {System.out.println("Please continue shopping");
        }
}

http://stackoverflow.com/questions/20596624/cant-get-java-to-assign-a-value-to-a-variable-using-if-statement — Rakesh KR, Dec 16 '13 at 15:21

score 1 · Answer 1 · answered Dec 16 '13 at 15:16

1

To compare String objects, use equals(String myValue) method, not ==

answered Dec 16 '13 at 15:16

k4sia

414
1
6
18

score 1 · Accepted Answer · answered Dec 16 '13 at 15:17

1

To compare objects in java use .equals() method instead of "==" operator

change

if(decision == "Yes")

to

if("Yes".equals(decision))

if you want to ignore case use .equalsIgnoreCase() method

 if("Yes".equalsIgnoreCase(decision))

answered Dec 16 '13 at 15:17

Prabhakaran Ramaswamy

25,706
10
57
64

score 0 · Answer 3 · answered Dec 16 '13 at 15:17

0

here ->if(decision == "Yes")

use

if(descision.equals("Yes"));

answered Dec 16 '13 at 15:17

Nambi

11,944
3
37
49

Java try catch returning false variable

3 Answers3