2

I want to get the chosen language from the Form1 combobox and enable other forms to view the language. The combobox has approximately 20 languages, so yes quite a few you could say! I have a method called ComboBoxLang_SelectedIndexChanged (occurs when the language in the combobox is changed):

// Works fine in Form1.cs
private void ComboBoxLang_SelectedIndexChanged(object sender, EventArgs e)
{
    string selectedItem = this.comboBoxLang.GetItemText(this.comboBoxLang.SelectedItem);

    comboBox2.Items.Clear();

    if (selectedItem == "English")
    {
        ToEnglish();
    }

    else if (selectedItem == "French")
    {
        ToFrench();
    }

    // And so on...
}

For the moment, to test that it works I just want to display a message of the language chosen in another form. I have researched and have tried multiple ways, but obviously I am going wrong somewhere! I thought may be using the get and set method would be most useful but I'm really not sure. I want the MessageBox to say "English" or whatever the selection is.

Another example, I know that using

Form1 f1 = new Form1();

... in the second form that is trying to retrieve the value is incorrect as it just gets the hard-coded text and I just want the actual value that has been entered. So I wasn't sure if I should use

private Form1 f1;

... in the second form instead. I am really confused.

I know this is a common question but I can't seem to find a solution.

lornasw93
  • 182
  • 4
  • 26
  • 4
    if anyone gave me $0,01 every time someone asks "how to access XYZ in another form" here I'd be richer than Bill Gates by now. – Federico Berasategui Dec 16 '13 at 21:03
  • 2
    You just need to pass the text you are interested in from one form to the next instead of directly referencing. [Similar](http://stackoverflow.com/questions/20617298/i-cant-call-my-method-from-class-to-form/20617386#comment30855487_20617386) question from earlier today – KSdev Dec 16 '13 at 21:07

3 Answers3

1

Lets do it via observer

public static class LanguageChangeObserver
{
    private static object _lock = new object();
    public delegate void LanguageHandler(string lang);

    public static event LanguageHandler LanguageChanged;

    public static void  Notify(string lang)
    {
        lock (_lock)
        {
            if (LanguageChanged != null)
                LanguageChanged(lang);
        }
    }

}

With this, all forms can subscribe to the event LanguageChanged and the form Form1 can "notify" - all other forms will get the info

Edit

The observer pattern is when you have classes that "observe" changes in other classes. In .net observer is implemented using Events and Delegates. Sounds scary but in reality it makes it simple. You subscribe to class event and observe the change you want to observe. In this case, when language is changed in the Form1, you should call LanguageChangeObserver.Notify(...). The other forms, when created, should subscribe to LanguageChanged event. 

LanguageChangeObserver.LanguageChanged += <form_method_with_signature_of_LanguageHandler>;

If the form is closed and about to be disposed, you should unsubscribe from the observing because wired and not un-wired handlers is common method of memory leaks in .Net

LanguageChangeObserver.LanguageChanged -= <form_method_with_signature_of_LanguageHandler>;

Lock will synchronize your code and make sure, you change one language at the time. I hope this helps.

T.S.
  • 18,195
  • 11
  • 58
  • 78
0

an easy way would be to make a public class and store combobox value in its string variable. and then (within other form) take that string value from that class

user3103111
  • 3
  • 3
0

I have managed to create a solution! See the link for my answer but in another related question of mine with an explanation and code:

https://stackoverflow.com/a/21310270/2952390

SO simple!

Community
  • 1
  • 1
lornasw93
  • 182
  • 4
  • 26