Android Listview row repeating item

Question

I have a list where on specific number(position) that i get from shared preferences an imageview should be shown(indicates what song is currently playing) . But i get the position,but that item is showing on other rows as well. The problem is occurring when i scroll the list.

*This is happening when i exit another activity, and on my on resume i to this:

@Override
protected void onResume() {
    super.onResume();
    if(AlbumDetails.mediaPlayer!=null)
    adapter = new PlaylistAdapter(this, songs);
    list.setAdapter(adapter);
}

Here is my code:

public class PlaylistAdapter extends BaseAdapter {

    private Activity activity;
    private static LayoutInflater inflater = null;
    private ArrayList<Songs> data;
    private DatabaseHelper db;
    private SharedPreferences prefs;
    int playpos;

    public PlaylistAdapter(Activity a, ArrayList<Songs> songs) {
        activity = a;
        data = songs;
        db = new DatabaseHelper(a);
        inflater = (LayoutInflater) activity
                .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        prefs = activity.getSharedPreferences("com.darkovski.quran",
                Context.MODE_PRIVATE);
        playpos = prefs.getInt("posPlaying", -1);
    }

    public int getCount() {
        return data.size();
    }

    public Object getItem(int position) {
        return position;
    }

    public long getItemId(int position) {
        return position;
    }

    public View getView(final int position, View convertView,
            final ViewGroup parent) {
        View vi = convertView;
        if (convertView == null)
            vi = inflater.inflate(R.layout.song_item, parent, false);

        ImageView download = (ImageView) vi
                .findViewById(R.id.playlist_item_download);
        db.openDB();
        if (db.isDownloaded(data.get(position).getNumber(), data.get(position)
                .getRecitorName(), data.get(position).getRecitorID()))
            download.setImageResource(R.drawable.download_yes);
        else {
            download.setImageResource(R.drawable.download_no);
            download.setOnClickListener(new OnClickListener() {
                @Override
                public void onClick(View v) {

                    new DownloadFileFromURL(activity, data.get(position)
                            .getRecitorName(), data.get(position).getTitle(),
                            data.get(position).getLink(), data.get(position)
                                    .getNumber(), data.get(position)
                                    .getRecitorID()).execute();
                    if (!db.isDBOpen())
                        db.openDB();
                    db.addDownloaded(data.get(position).getNumber(),
                            data.get(position).getLink(), 0, data.get(position)
                                    .getRecitorID(), "", data.get(position)
                                    .getTitle());

                    Toast.makeText(activity,
                            "Downloading " + data.get(position).getTitle(),
                            Toast.LENGTH_SHORT).show();

                }
            });
        }
        db.closeDB();

        TextView number = (TextView) vi.findViewById(R.id.playlist_item_num);
        TextView title = (TextView) vi.findViewById(R.id.playlist_item_reciter);
        title.setText(data.get(position).getTitle());
        number.setText((position + 1) + "");
        ImageView eq = (ImageView) vi.findViewById(R.id.playlist_item_equlizer);
        //this is where i show the item
        if (playpos == position) {
            eq.setVisibility(View.VISIBLE);
        }

        return vi;
    }
}

And this is how it looks:

enter image description here

Accept the answer if you found it help full. This is not a Barbour shop... — Triode, Dec 17 '13 at 18:54
@Triode if u scroll down you'll see that there is an accepted answer — Darko Petkovski, Dec 17 '13 at 19:09

score 7 · Accepted Answer · answered Dec 17 '13 at 15:26

7

its because of this statement

if (playpos == position) {
        eq.setVisibility(View.VISIBLE);
    }

the listview recycles views so if you notice the first row and the last row is showing the same. That is because the first row was recycled to the last row

you can fix this by adding an else onto the if so it would look like

if (playpos == position) {
        eq.setVisibility(View.VISIBLE);
}else{
    eq.setVisibility(View.GONE);
}

answered Dec 17 '13 at 15:26

tyczj

71,600
54
194
296

Soo easy - why I've didn't think of that :) Thanks! – Darko Petkovski Dec 17 '13 at 15:31

score 0 · Answer 2 · edited May 23 '17 at 12:23

0

If you are extending BaseAdapter in you Adapter class then this solution will work. https://stackoverflow.com/a/28791031/4531507

edited May 23 '17 at 12:23

Community

1
1

answered Mar 14 '16 at 16:02

Rahul Sharma

5,949
5
36
46

Android Listview row repeating item

2 Answers2

Linked