project on writing phone book file

Question

 struct phone
 {
      char fname[20];
      char lname[20];
      char pnumber[20];
 };

int main()
{

 int x=0;
 int n;
 char s[100];

 FILE * f;

 f = fopen("phone book","r");

 if (f != NULL)
 {
     printf("file exist !\n");   
     while(!(feof(f)))
     {
           fscanf(f,"%s,%s,%s",s[x].fname,s[x].lname,s[x].pnumber);
           x++;
     }
 }

 printf("1-   add");
 printf("2-   query");
 scanf("%d",&n);

if(n==1)
    printf("%s",s[n].fname);

if(n==2)
    fclose(f);

}

I write this program and there is a problem in fscanf

the comment for the error

 'main':|
  request for member 'fname' in something not a structure or union|
  request for member 'lname' in something not a structure or union|
  request for member 'pnumber' in something not a structure or union|
  request for member 'fname' in something not a structure or union|
 : variable 's' set but not used [-Wunused-but-set-variable]|

 : control reaches end of non-void function [-Wreturn-type]|
 ||=== Build finished: 4 errors, 2 warnings (0 minutes, 0 seconds) ===|

Format your code, it's unreadable. ----- "and there is a problem in fscanf" - yeah, `fscanf()` is itself the problem, don't use it. You can use `fgets()` to read lines from a file, then `strchr()`, `strstr()`, `strtok_r()` and `strtol()` to parse each line. — , Dec 23 '13 at 09:59

score 1 · Answer 1 · answered Dec 23 '13 at 10:03

1

s is declared to be char s[100];, so s[x] is a char and not a struct phone. You need to declare s as struct phone s[100]; and the first of your problems will go away.

answered Dec 23 '13 at 10:03

Paul Hankin

54,811
11
92
118

haccks · Accepted Answer · 2013-12-23T10:12:35.153

For the errors

request for member 'fname' in something not a structure or union|
request for member 'lname' in something not a structure or union|
request for member 'pnumber' in something not a structure or union|
request for member 'fname' in something not a structure or union|
: variable 's' set but not used [-Wunused-but-set-variable]|

Change

char s[100];  // is not a structure. You need to declare it as structure

to

struct phone s[100];

and for the error

control reaches end of non-void function [-Wreturn-type]|

as return type of main is int ( a non-void function whose return type is other than void) you need to add a return 0; statement before the closing brace } of main.

score 0 · Answer 3 · edited May 23 '17 at 12:11

0

Well, the compiler is right. You declare

char s[100];

and try to access its members like it would be a structure array. It is just a char array.

I think you wanted to do something like

struct phone s[100];

This will declare an array s of 100 struct phone's.

Also, note that while(!feof(f)) it's not recommended to use in this case: Why is “while ( !feof (file) )” always wrong?

edited May 23 '17 at 12:11

Community

1
1

answered Dec 23 '13 at 10:04

Paul92

8,827
1
23
37

project on writing phone book file

3 Answers3