Variables when minified

Question

Given that when minified JavaScript variables will be simplified what is the best way to declare or use the variable for window, document, undefined, etc.?

1st way

(function ($, win, doc, undefined) {
}(jQuery, window, document));

2nd way

(function () {
    var $ = jQuery,
        win = window,
        doc = document,
        undefined;
}());

It seems like, as the goal of minifying is to drop the filesize, the best answer would be the 1st because it is shorter. — Robbie Wxyz, Jan 02 '14 at 04:20
The 2nd way is better for its readability. Many tools are available to minify the code that can compact the code than in 1st way. — Kunj, Jan 02 '14 at 04:33
@KunJ see what I said in my [answer](http://stackoverflow.com/a/20876289/2709301). — tjons, Jan 02 '14 at 04:37

score 3 · Accepted Answer · answered Jan 02 '14 at 04:26

For minified code, shorter (less bytes to be transferred) is always better. So, for a minified file the first option would be best:

(function($,w,d,u){})(jQuery,window,document); 46 characters.

Compared to the other option:

(function(){var $=jQuery,w=window,d=document,u=undefined;})(); 62 characters.

^{P.S. You did your closures wrong. (function(){}()) will throw a syntax error. (function(){})() won't.}

score 2 · Answer 2 · edited May 23 '17 at 12:19

2

It doesn't matter, write your code keeping a legible and maintainable format, and for production then use a minifier that will shrink your code to something really small.

You can even automatize the whole process by using something like make

Keep in mind that premature optimization is the root of all evil (you're trying to minimize the size of your code beforehand)

edited May 23 '17 at 12:19

Community

1
1

answered Jan 02 '14 at 04:27

higuaro

15,730
4
36
43

score 1 · Answer 3 · answered Jan 02 '14 at 04:20

1

I don't believe it really makes a difference, except that the second way takes up more space. I personally prefer the second way, as I think it is more readable.

But for minifying, you DEFINITELY want to go with the first way. Much less space used.

answered Jan 02 '14 at 04:20

tjons

4,749
5
28
36

Variables when minified

3 Answers3