How to write multiple foreach condition in a single line

Question

my code is not working it's showing error in condition.

 <?
 foreach($_POST['check'] as $value )   
 foreach($_POST['emp'] as $value2 )     
 { 
 mysql_query("insert into tb_recived_jobs set job_id='$value'emp_id='$value2'");  
 }     
 ?>

[`mysql_*` functions are deprecated and will soon be removed. Please use `mysqli_*` or PDO instead.](http://stackoverflow.com/a/20767765/1612146) — George, Jan 06 '14 at 12:15
You should consider building one large query with string concatination. An extra query for every row is very unperformant and can make your page/script very slow. — Steini, Jan 06 '14 at 12:15
Nested foreach creates a cross-product. I don't think that's what you really want. The error you're getting has nothing to do with `foreach`, it's probably because you left out the `,` between the variables in the SQL. — Barmar, Jan 06 '14 at 12:17
It's always a good idea to wrap the bodies of your `foreach` with `{}`, even if it's one line. — Barmar, Jan 06 '14 at 12:20

Manish Jangir · Answer 1 · 2014-01-06T12:19:13.943

1

You should use For loop to do this

$count = count($_POST['check']);

for($i=0;$i<=$count;$i++) {
    $value= $_POST['check'][$i];
    $value2= $_POST['emp'][$i];
    mysql_query("insert into tb_recived_jobs(job_id,emp_id) values('$value','$value2')"); 
}

edited Jan 06 '14 at 12:19

answered Jan 06 '14 at 12:13

Manish Jangir

5,329
4
42
75

All I expected you to do was add a comma, not switch to the other syntax! But OK. – Barmar Jan 06 '14 at 12:21

PRAISER · Answer 2 · 2014-01-06T15:34:12.690

correct your SQL Query like this :

"insert into tb_recived_jobs set job_id='$value' emp_id='$value2'"

you are missing one space between first value and second column, make an INSERT SQL query like this one helps much more:

"INSERT INTO `tb_recived_jobs` (`job_id`, `emp_id`) VALUES ('$value', '$value2');"

UPDATE: I just realized what is wrong exactly, cause here you have two arrays and you want to insert their values by a query, in this case both arrays should have same length to everything goes well

$checks = $_POST['check'];
$emps = $_POST['emp'];

$length = count($checks);
if ($length === count($emps)) {
    for ($i = 0; $i < $length; $i++) {
        $sql = "INSERT INTO `tb_received_jobs` (`job_id`, `emp_id`) VALUES ('{$checks[$i]}', '{$emps[$i]}');";
        //  send the query
    }
}

this should work properly.

Space isn't required, but comma is. – Barmar Jan 06 '14 at 12:20 — Barmar, Jan 06 '14 at 12:20

score 0 · Answer 3 · answered Jan 06 '14 at 12:17

0

You can merge two array $_POST['check'] and $_POST['emp'] in one array after than you can use foreach for this.

answered Jan 06 '14 at 12:17

Avish Shah

111
7

What merging function do you suggest? `array_merge()` isn't correct for this. – Barmar Jan 06 '14 at 12:22
Yes array_merge is not correct need to make custom function. it will makes according array – Avish Shah Jan 06 '14 at 12:29

score 0 · Answer 4 · answered Jan 06 '14 at 12:26

try this as i understand if you want to insert each $_POST['emp'] for every $_POST['check']

<?
foreach($_POST['check'] as $value ) 
{  
 foreach($_POST['emp'] as $value2 )     
 { 
    mysql_query("INSERT INTO `tb_recived_jobs`(job_id, emp_id) VALUES('$value', '$value2')") or die(mysql_error());  
 } 
}    
 ?>

How to write multiple foreach condition in a single line

4 Answers4