local variables overwrite in function run multiple times in a loop

Question

Hey I'm having small issue here.

Question: how can I create unique variables for a function so when called multiple times, the variables will hold what they should (not swap)

keep in mind I have to keep it asynchronous as the loop will be large and not running it async would hit the performance very hard

I have a function which draws items on canvas. Then I run this function in for loop to draw few canvases depending on some data in array.

so simplified version:

function renderCanvas(canvas, dID) {
    var mName, bName, sName, tName;
    this.layerCounter = mainData[dID]['layerCount'];
    console.debug(designID + " has " + layerCounter + " layers");
    /* that gives 2 layers for first item and 3 for second)*/

    tctx2.clearRect(0, 0, tc2.width, tc2.height);
    var imgPath = sName;
    imgObj = new Image();
    imgObj.src = "img/" + imgPath;
    imgObj.onload = function () {

        tctx2.drawImage(imgObj, 0, 0, w, h, 0, 0, dw, dh);
        layerCounter--;
        console.debug(designID + " has " + layerCounter + " layers");

        tctx3.clearRect(0, 0, tc2.width, tc2.height);
        var imgPath = tName;
        imgObj = new Image();
        imgObj.src = "img/" + imgPath;
        imgObj.onload = function () {

            tctx3.drawImage(talphaObj, 0, 0, w, h, 0, 0, dw, dh);
            layerCounter--;
            console.debug(designID + " has " + layerCounter + " layers");
        };
    }
}
for (var i = 0; i < xArr.length; i++) {
    var cDID = xArr[i];
    renderCanvas(contexts[i], cDID);
}

Any suggestions? I'm fairly new to programming so I'm probably missing something very easy.

Don't understand your question.. what value you want to assign to that variable ? BTW context[i] is not declared in you code — Merlin, Jan 07 '14 at 15:41

score 8 · Accepted Answer · edited May 23 '17 at 12:15

hitting a javascript function (that has asynchronous behaviour) like this you want to be using a closure:

//im assuming contexts array is defined some where up here??

for (var i = 0; i < xArr.length; i++) {
    var cDID = xArr[i];

    //the following function will self execute on each loop
    (function (c, d) {
        //Insert your renderCanvas function body here
        //but use variable c and d in this closure.
        //The values you have passed into this closure
        //are now 'fixed' in this scope and cannot
        //be interfered with by subsequent iterations
    })(contexts[i], cDID);
}});

Basically you are wrapping your function in another scope so that on the next iteration of the now async loop you cannot overwrite your local variables (i think this is the behaviour of variables being 'swapped' that you refer to)

this gives a good explanation of javascript closure, it can be a confusing subject! - How do JavaScript closures work?

Also as daguru says your contexts array is not defined anywhere? — alfonsob, Jan 07 '14 at 16:01

local variables overwrite in function run multiple times in a loop

1 Answers1

Linked