Foreach iteration showing each record several times

Question

I have created Linq-to-SQL for a view of SQL Server, now I'm trying to display record on view, it's done :) but

problem is that it shows each name 26 times, why?
How to put it in gridview kinda thing in MVC?

Controller:

namespace EmployeeAttendance_app.Controllers
{
    public class HomeController : Controller
    {
        public ActionResult Index()
        {
            ViewBag.Message = "Employee Attendance";
            var DataContext = new EmployeeAtdDataContext();
            var EmployeeAtd = from emp in DataContext.EmployeeAtds
                         select emp;
            return View(EmployeeAtd);
        }

       }

View:

<ul>
 @foreach (EmployeeAttendance_app.Models.EmployeeAtd emp in (IEnumerable<Object>)ViewData.Model) 
 {
     <li>@emp.EmplName</li>
 }
</ul>

Model contains Linq-to-SQL class named EmployeesAtd.

View has been created via this query:

SELECT        
    dbo.HrEmployee.EmplID, dbo.HrEmployee.EmplName, dbo.AtdRecord.RecDate, 
    dbo.AtdRecord.RecTime, dbo.HrDept.DeptName
FROM            
    dbo.HrDept 
RIGHT OUTER JOIN
    dbo.HrEmployee ON dbo.HrDept.DeptID = dbo.HrEmployee.DeptID 
LEFT OUTER JOIN
    dbo.AtdRecord ON dbo.HrEmployee.EmplID = dbo.AtdRecord.EmplID

Isn't in your case `from emp in DataContext.EmployeeAtds select emp;` exactly as `DataContext.EmployeeAtds`? In view do you need to cast to `IEnumerable — Adriano Repetti, Jan 16 '14 at 11:30
To expand on Adriano's suggestion, if you strongly type your view you should be able to shorten your loop code to: @foreach (var emp in ViewData.Model) — SethMW, Jan 16 '14 at 11:36
@James as SethMW said, make your view strongly typed. No need for all those casts (and your code will be more clear). That said, IMO problem is in your `RIGHT OUTER JOIN` because an employee may appear more than once in the other tables. I'd suggest to write an ad-hoc query for that or...simply use `DataContext.EmployeeAtds.Distinct(new ComparerByName())` in your controller. Where `CompareByName` is an equality comparer that consider only `EmplName`. — Adriano Repetti, Jan 16 '14 at 11:42
ok sir i did my best to correct query but couldn't, could u please make it correct ? the query not c# code etc, just my query so it would not display records several times — James, Jan 16 '14 at 12:16
@James use `Distinct()` to make records unique (by employee's name). See my previous comment. — Adriano Repetti, Jan 16 '14 at 12:27

score 0 · Answer 1 · answered Jan 16 '14 at 11:33

0

Other than cleaning up the things Adriano pointed out, I don't see anything wrong with that. You said EmployeeAtds is a SQL View, right? I would guess you have some sort of join in there that is duplicating rows.

answered Jan 16 '14 at 11:33

SethMW

1,062
1
9
10

score 0 · Answer 2 · edited May 23 '17 at 11:57

0

Try to move boxing before loop:

var emps = (IEnumerable< Object >)ViewData.Model;

@foreach(EmployeeAttendance_app.Models.EmployeeAtd emp in emps)

To show data in GridView you have to use some javascript lib. grid controls for ASP.NET MVC?

edited May 23 '17 at 11:57

Community

1
1

answered Jan 16 '14 at 11:35

emilpytka

763
7
19

Foreach iteration showing each record several times

2 Answers2