Delay class questions (C#)

Question

I created a static class called "Delay" which basically accepts argument of (double delay, ThreadStart action). Here it is:

 public class Delay
{
    public static void Execute(double delay, ThreadStart action)
    {
        Delay.Execute((int)delay, action);
    }

    public static void Execute(int delay, ThreadStart action)
    {
        Timer t = new Timer(delay);

        t.Elapsed += new ElapsedEventHandler(delegate(object sender, ElapsedEventArgs e)
        {
            t.Stop();
            action();
            t.Dispose();
            t = null;
        });

        t.Start();
    }

    private Timer t;

    public Delay(int delay, ThreadStart action)
    {
        t = new Timer(delay);

        t.Elapsed += new ElapsedEventHandler(delegate(object sender, ElapsedEventArgs e)
        {
            if (t != null)
            {
                t.Stop();
                action();
                t.Dispose();
            }

            t = null;
        });
    }

    public void Execute()
    {
        t.Start();
    }

    public void Cancel()
    {
        if (t != null)
        {
            t.Stop();
            t.Dispose();
        }

        t = null;
    }
}

I have a few questions.

Is it really bad? My friend told me it'd give me errors for sure, but I haven't experienced any.
Is there a way to improve it? It works fine now, but I don't want it to leak memory in the future.

Best regards.

SO is for specific problems. As it seems you don't have any problems (as your code seems to run fine for you), SO might be the wrong place. This looks more like a question for the folks at [codereview.stackexchange.com](http://codereview.stackexchange.com/). — KeyNone, Jan 18 '14 at 17:15
http://stackoverflow.com/questions/620733/memory-leak-in-c-sharp — DayTimeCoder, Jan 18 '14 at 17:16

Selman Genç · Answer 1 · 2014-01-18T18:03:04.700

4

You don't need any of this.Simply you can use async/await feature like:

public async Task Execute(double delay, ThreadStart action)
{
    await Task.Delay((int)delay).ContinueWith((x) => action());
}

edited Jan 18 '14 at 18:03

answered Jan 18 '14 at 17:16

Selman Genç

100,147
13
119
184

Delegate System.Action does not take 0 arguments. – user3171969 Jan 18 '14 at 17:51
just change this: `() => action()` to `(x) => action()` – Selman Genç Jan 18 '14 at 18:03
And how would I use it? My current code is : Delay.Execute(60000, () => SomeMethod()), However, the compiler says that "Because this call is not awaited...". – user3171969 Jan 18 '14 at 19:25
It's a warning, you can ignore it or you can make your current method async and await that task like this: `"await Delay.Execute(60000, () => SomeMethod())"` – Selman Genç Jan 18 '14 at 19:29

Delay class questions (C#)

1 Answers1