What is wrong with my PHP email code; it won't redirect to thank you page

Question

Curious as to what is wrong with the following php code which sends an email when a contact form is filled out and submitted. The email arrives perfectly but instead of redirecting it gives the following error:

Warning: Cannot modify header information - headers already sent by (output started at /home4/ranchoba/public_html/marvan/marvan/send.php:1) in /home4/ranchoba/public_html/marvan/marvan/send.php on line 112

I've tried calling the php file by the action in the form as well as by placing a in the very first line of the page. Neither one works.

PHP Code:

<?php
error_reporting(E_ALL); ini_set('display_errors', 1);
//if the form is submitted, go ahead and send the email to ops
ob_start();

if ($_POST['is_form_submitted'] == "yes")
{
//Send email to ops of this request-----------------------------------------------------------------------------------

// multiple recipients

$to = 'blah@gmail.com';

// subject

$subject = "Contact Request: ".$_POST['name'];

// message
$message = '
<html>
<head>
<title>Re: Marvan Site Contact Request</title>
<style type="text/css">
<!--
.style4 {font-family: Arial, Helvetica, sans-serif; font-size: 12; }
.style5 {font-size: 12}
.style6 {font-family: Arial, Helvetica, sans-serif; font-size: 12; font-weight: bold; }
-->
</style>
</head>
<body>';
$message=$message.'
<table width="450" border="0" align="center" cellpadding="4" cellspacing="0" style="border-color:#CCCCCC; border-style:solid; border-width:1px; background-color:#FFFFFF; padding-top:3px;">&nbsp;
  <tr>
    <td width="430" style="height:auto;" valign="top">';

$message=$message.'<img src="http://www.blah.com/blah/images/logo.png">';

$message=$message.'<hr>';

$message=$message.'<h2 style="font-family:Arial, Helvetica, sans-serif; color:#B58736">Contact Request </h2>';

$message=$message.'
<table width="486" border="0" align="center" cellpadding="4" cellspacing="2">
      <tr>
        <td colspan="4" valign="top"><div align="left" class="style4"><span style="color:#000000; font-weight:bold;">Contact Details: </span></div></td>
        </tr>

      <tr>
        <td width="145" valign="top"><div align="left" class="style4">Name :</div></td>
        <td width="1" valign="top"><span class="style5"></span></td>
        <td width="984" colspan="2" valign="top"><div align="left" class="style6">';
          $message = $message. $_POST['name'];
          $message = $message.'</div></td>
      </tr>
      <tr>
        <td valign="top"><div align="left" class="style4">Email :</div></td>
        <td valign="top"><span class="style5"></span></td>
        <td colspan="2" valign="top"><div align="left" class="style6">';
          $message = $message. $_POST['email'];
          $message = $message.'</div></td>
      </tr>
      <tr>
        <td valign="top"><div align="left" class="style4">Subject :</div></td>
        <td valign="top"><span class="style5"></span></td>
        <td colspan="2" valign="top"><div align="left" class="style6">';
          $message = $message. $_POST['subject'];
          $message = $message.'</div></td>
      </tr>
      <tr>
        <td valign="top"><div align="left" class="style4">Phone :</div></td>
        <td valign="top"><span class="style5"></span></td>
        <td colspan="2" valign="top"><div align="left" class="style6">';
          $message = $message. $_POST['phone'];
          $message = $message.'</div></td>
      </tr>                     
      <tr>
        <td valign="top"><div align="left" class="style4">Message :</div></td>
        <td valign="top"><span class="style5"></span></td>
        <td colspan="2" valign="top"><div align="left" class="style6">';
          $message = $message. $_POST['message'];
          $message = $message.'</div></td>
      </tr>';

$message = $message.'         
      <tr> <tr><td colspan="4" valign="top"><span class="style5"></span></td>
        </tr>'; 
$message = $message.' 
    </table>    
    <br /></td>
  </tr>
</table>
<p>&nbsp;</p>
</body>
</html>
';

// To send HTML mail, the Content-type header must be set
$headers  = 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";

// Additional headers
/*              $headers .= 'To: Mary <mary@example.com>, Kelly <kelly@example.com>' . "\r\n";*/
/*              $headers .= 'Cc: birthdayarchive@example.com' . "\r\n";
$headers .= 'Bcc: birthdaycheck@example.com' . "\r\n";*/

// Mail it
mail($to, $subject, $message, $headers);
//end of Send Email to Client -------------------------------------------------------------- 

//redirect to the thank you page
header('Location: http://www.blah.com/blah/thank-you.php');

} //end of if ($_POST['is_form_submitted'] == "yes")
?>

Try html header redirect instead of php. – Abu Nooh Jan 18 '14 at 21:47 — Abu Nooh, Jan 18 '14 at 21:47

score 0 · Answer 1 · answered Jan 18 '14 at 21:49

0

Maybe you have space before <?php tag in your scripts. Check it please and remove them. Also use UTF-8 file encoding without BOM

answered Jan 18 '14 at 21:49

Victor Bocharsky

11,930
13
58
91

mseifert · Answer 2 · 2014-01-19T00:43:19.480

0

It is best to find where you are outputting a space or line that is causing the header() to fail. But if you cannot, try this to clear the buffer before header().

        if (ob_get_length() > 0 ) {
            ob_clean();
            flush();
        }

edited Jan 19 '14 at 00:43

answered Jan 18 '14 at 21:54

mseifert

5,390
9
38
100

What is wrong with my PHP email code; it won't redirect to thank you page

2 Answers2