19

I have the following HTML with data attributes - I want to write some jQuery that will loop through the HTML and collect the data attributes and put them into an array - could anyone assist as I'm getting an error.

I am trying to use the data() attribute - can you see what I'm doing wrong?

<span class="winners" data-userid="123" data-position="1" data-fullname="neil">
<span class="winners" data-userid="234" data-position="2" data-fullname="Ron">
<span class="winners" data-userid="421" data-position="3" data-fullname="Philip">
var multi = $('.winners');
var winners_array = [];

$.each(multi, function (index, item) {
    winners_array.push( {name: 'fullname', value: item.data('fullname')} );  
});

console.log(winners_array);

Console error:

item.data is not a function

TylerH
  • 20,799
  • 66
  • 75
  • 101
Zabs
  • 13,852
  • 45
  • 173
  • 297

3 Answers3

39

item is not a jQuery object, the arguments for each are the index and the native DOM element

var multi = $('.winners');
var winners_array = [];

$.each(multi, function (index, item) {
    winners_array.push( {name: 'fullname', value: $(item).data('fullname')} );  
});

using a map would be easier

var winners_array = $.map($('.winners'), function(el) {
     return {name: 'fullname', value: $(el).data('fullname')}
});
adeneo
  • 312,895
  • 29
  • 395
  • 388
6

I understand you should use $(item), instead data only. Kindly find the code below:

<script type="text/javascript">
        var multi = $('.winners');
        var winners_array = [];

        $.each(multi, function (index, item) {
            winners_array.push( {name: 'fullname', value: $(item).data('fullname')} );  
        });

        console.log(winners_array);
    </script>
Vinay
  • 325
  • 1
  • 8
3

Use item.dataset.fullname instead.

var multi = $('.winners');
var winners_array = [];

$.each(multi, function (index, item) {
    winners_array.push( {name: 'fullname', value: item.dataset.fullname} );  
});

console.log(winners_array);
Jake
  • 660
  • 1
  • 7
  • 18
  • 1
    This is only supported in IE11, and generally isn't supported in older browsers at all. You'd be better of using `getAttribute('data-fullname')`. Also note that jQuery's `data()` stores data internally, so if the value is set or changed with `data()` this won't work either. – adeneo Jan 23 '14 at 11:52
  • Are you sure? I just verified it in the Chrome console. – Jake Jan 23 '14 at 12:22