Java replaceAll() regex does not work

Question

I'm trying to replace all special characters with a "%", like:

"123.456/789" -> "123%465%798"

my regular expression is:

[^a-zA-Z0-9]+

In online tools* it works perfecly, but in java

s.replaceAll("[^a-zA-Z0-9]+", "%");

strings remain untouched.

*I tried: http://www.regexplanet.com/ http://regex101.com/ and others

`s = s.replaceAll("[^a-zA-Z0-9]+", "%");` Strings are immutable. — Alexis C., Jan 29 '14 at 16:14

score 5 · Accepted Answer · answered Jan 29 '14 at 16:16

5

Strings are immutable. You forgot to reassign new String to the s variable :)

s = s.replaceAll("[^a-zA-Z0-9]+", "%");
 // ^ this creates a new String

answered Jan 29 '14 at 16:16

Amit Sharma

5,844
5
25
34

3

I'm not your buddy, pal. – crush Jan 29 '14 at 16:18
2

What `dude` are you all talking about ? :) – Amit Sharma Jan 29 '14 at 16:18

score 4 · Answer 2 · answered Jan 29 '14 at 16:17

replaceAll() like all methods in String class, DO NOT modify String on which you invoke a method. This is why we say that String is immutable object. If you want to 'modify' it, you need to do

s = s.replaceAll("[^a-zA-Z0-9]+", "%");

In fact you don't modify String s. What happens here is that new String object is returned from a function. Then you assign its reference to s.

score 1 · Answer 3 · answered Jan 29 '14 at 16:16

1

You can't change a String, instead replaceAll returns a new value. so you should use it like this

String newStr = s.replace(...)

answered Jan 29 '14 at 16:16

Yanis

4,847
2
17
17

1

It's fantastic how fast problems are being solved on stackoverflow – Yanis Jan 29 '14 at 16:17
1

When they are this simple... – crush Jan 29 '14 at 16:18

score -1 · Answer 4 · answered Jan 29 '14 at 16:18

Working code as per your expectations :)

import java.util.regex.Pattern;


public class Regex {

    public static void main(String[] args) {
        String s = "123.456/789";
        Pattern p = Pattern.compile("[^a-zA-Z0-9]+");
        String newStr = s.replaceAll("[^a-zA-Z0-9]+", "%");
        System.out.println(s + " -> " + newStr);
    }
}

Output : 123.456/789 -> 123%456%789

Java replaceAll() regex does not work

4 Answers4

Linked

Related