Similar variables are not similar

Question

My searching part of code:

String neededShop = "not found";
float min_price=999999;
ProductHandler ph = new ProductHandler(this);
prod=ph.getAllProducts();
for(int i = 0 ; i<prod.size(); i++)
{
    if(prod.get(i).getName()==SearchProduct)
    {
        if(min_price>prod.get(i).getPrice())
        {   
            min_price=prod.get(i).getPrice();
            neededShop = prod.get(i).getShop();
        }
    }
}

in this part: if(prod.get(i).getName()==SearchProduct)

prod    [0] name    "Cat" (id=830032142800) 
SearchProduct   "Cat" (id=830032120832)

When it is comparing it returns false, in spite of they are similar. Any ideas why?

possible duplicate of [How do I compare strings in Java?](http://stackoverflow.com/questions/513832/how-do-i-compare-strings-in-java) — Makoto, May 24 '15 at 03:19

score 2 · Accepted Answer · answered Feb 01 '14 at 15:07

2

String comparison is not obtained by using the == operator.
You get the comparison by testing equals().

Try this:

if(prod.get(i).getName().equals(SearchProduct))

answered Feb 01 '14 at 15:07

Phantômaxx

37,901
21
84
115

Hmm when i was trying equalsIgnoreCase it doesn`t work. Now it works, thanks – newbie Feb 01 '14 at 15:11

score 0 · Answer 2 · answered Feb 01 '14 at 15:18

0

It isn't magic dude, its java... :) double equal == are used to primitive types only For comparing objects u need to check using equals() method

answered Feb 01 '14 at 15:18

Kapil Vij

312
2
7

score 0 · Answer 3 · answered Feb 01 '14 at 15:18

0

In Java, for comparisson objects of non-primitive data type you must use equals() method.

answered Feb 01 '14 at 15:18

Denys Vasylenko

2,135
18
20

Similar variables are not similar

3 Answers3