Removes 1 whitespace but not 2

Question

I'm using the code below to trim data to be sent to an SQL on a PHP page.

<script>$(function() { 
                $("#nameselect").change(function() {
                $("#jobnoselect").load("getter.php?choice=" + $.trim($("#nameselect").val()).replace(' ', '+'));
                $("#pagetable").empty();
                });

            });
   </script>

Now it does work if the choice made is "Two Words" but if it is "Three Words Here" it does not and returns blank results. I'm not familiar with this language and another developer gave me this snippet a long time ago. Can anyone offer any help with it?

score 1 · Accepted Answer · answered Feb 03 '14 at 11:20

1

Replace using string as pattern is not global.

Change the code

$.trim($("#nameselect").val()).replace(' ', '+')

to

$.trim($("#nameselect").val()).replace(/\s/g, '+')

answered Feb 03 '14 at 11:20

Michal Brašna

2,293
13
17

score 0 · Answer 2 · answered Feb 03 '14 at 11:20

0

If you use php instead of javascript:

$foo = preg_replace( '/\s+/', ' ', $foo );

answered Feb 03 '14 at 11:20

Ana Claudia

501
6
16

score 0 · Answer 3 · edited Feb 03 '14 at 11:24

0

Use encodeURIComponent so that the space will be converted and sent.

<script>
$(function() { 
    $("#nameselect").change(function() {
        $("#jobnoselect").load("getter.php?choice=" + encodeURIComponent($("#nameselect").val()));
        $("#pagetable").empty();
    });
});
</script>

And in your php page use urldecode to retrieve the content.

edited Feb 03 '14 at 11:24

answered Feb 03 '14 at 11:21

Karthick Kumar

2,349
1
17
30

PHP automatically decodes parameters retrieved by GET, so no need to use urldecode on it. – Tularis Feb 03 '14 at 11:23

score 0 · Answer 4 · answered Feb 03 '14 at 11:21

You're better off serializing the value than actually replacing spaces with plus-signs. This is a better way:

<script type="text/javascript">
   $(function() { 
   $("#nameselect").change(function() {
      $("#jobnoselect").load("getter.php?choice=" + $("#nameselect").serialize());
      $("#pagetable").empty();
   });
});
</script>

Removes 1 whitespace but not 2

4 Answers4