custom listview with edittext,checkbox and textview

Question

I have a custom listview that contains an edittext,checkbox and two text views.Now i am hving a problem with the edittext values in my code.I am not able to get the correct value from the edittext.And also if i set the value of an edit text at one position in the list,that value is also set to edittexts at random positions in the listview.And i have the common problem of the values changing on scroll.Following is the code:

Activity:

protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_assess_list);
    prev = getIntent();
 final ListView listview = (ListView) findViewById(R.id.studentsListView);
 listview.setAdapter(new AssessmentAdapter(this, R.layout.assessment,
            StudentNames.student_name, StudentNames.studentRollNo));

}

Adapter:

public class AssessmentAdapter extends ArrayAdapter<String> {

Context context;
ViewHolder holder;
CheckBox present;
EditText marks;
int pos;
public static ArrayList<String> studentNames,studentRollNo,studentsPresent,marksObtainedList;
public AssessmentAdapter(Context context, int textViewResourceId,ArrayList<String> studentNames,ArrayList<String> studentRollNo) {
    super(context, textViewResourceId,studentNames);
    // TODO Auto-generated constructor stub
    this.context=context;
    AssessmentAdapter.studentNames=studentNames;
    AssessmentAdapter.studentRollNo=studentRollNo;
    studentsPresent=new ArrayList<String>();
    marksObtainedList=new ArrayList<String>();
    Log.d("No. of students",""+studentRollNo.size());
    for(int i=0;i<studentNames.size();i++)
    {
        studentsPresent.add("1");
        marksObtainedList.add("0");
    }

}
 static class ViewHolder { 

    CheckBox presentCB;
    TextView name,Rno;
    EditText marksObtained;
    Button save;
} 

public View getView(final int pos,View convertview,ViewGroup parent)
{
try
{
holder=null;
LayoutInflater inflater=(LayoutInflater)context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);

if(convertview==null)
{

    //rowView=inflater.inflate(org.example.attendance.R.layout.list_radio,parent,false);
    convertview=inflater.inflate(R.layout.assessment,null);
    holder=new ViewHolder();
    holder.presentCB=(CheckBox)convertview.findViewById(org.example.attendance2.R.id.presentCB);
    holder.name=(TextView)convertview.findViewById(org.example.attendance2.R.id.studNameTV);
    holder.Rno=(TextView)convertview.findViewById(org.example.attendance2.R.id.studRollNoTV);
    holder.marksObtained=(EditText)convertview.findViewById(org.example.attendance2.R.id.marksET);
    holder.save=(Button)convertview.findViewById(org.example.attendance2.R.id.saveButton);

    convertview.setTag(holder);
}

 else
{
    holder=(ViewHolder) convertview.getTag();
}
holder.name.setText(studentNames.get(pos));
holder.Rno.setText(studentRollNo.get(pos));

holder.save.setOnClickListener(new View.OnClickListener() {

    @Override
    public void onClick(View arg0) {
        // TODO Auto-generated method stub

    }
});

    holder.marksObtained.addTextChangedListener(new TextWatcher(){

    @Override
    public void afterTextChanged(Editable arg0) {
        // TODO Auto-generated method stub
        marksObtainedList.set(pos, arg0.toString());
    }

    @Override
    public void beforeTextChanged(CharSequence arg0, int arg1, int arg2,
            int arg3) {
        // TODO Auto-generated method stub

    }

    @Override
    public void onTextChanged(CharSequence arg0, int arg1, int arg2,
            int arg3) {
        // TODO Auto-generated method stub

    }

});
holder.presentCB.setOnClickListener(new View.OnClickListener() {

    @Override
    public void onClick(View v) {
        // TODO Auto-generated method stub
        if(studentsPresent.get(pos).equals("1"))
            {
                studentsPresent.set(pos, "0");
            }
            else 
            {
                studentsPresent.set(pos, "1");
            }       
    }
});
    //if(RadioChecked[pos])
    if(studentsPresent.get(pos).equals("1"))
    {
        holder.presentCB.setChecked(true);      
    }
//  else if(!RadioChecked[pos])
    else if(studentsPresent.get(pos).equals("0"))
    {
        holder.presentCB.setChecked(false);
    }   
    if(holder.marksObtained.getText().toString().equals(""))
    {
        marksObtainedList.set(pos,"0");
    }
    else
    {
        String marks=holder.marksObtained.getText().toString();
        marksObtainedList.set(pos,marks);
        Log.d(""+pos,marksObtainedList.get(pos));
    }
    holder.marksObtained.setText(marksObtainedList.get(pos));
}catch(Exception e)
{
}
return convertview;
}
 public boolean areAllItemsEnabled() 
 {
return true;
  }

  @Override
 public boolean isEnabled(int arg0) 
 {
return true;
  }

 }

Classic case of view recycling, you need to create an array to store your values. — Skynet, Feb 04 '14 at 09:45
if you make any change in edit-text means.You have to update the value on array also. — Yugesh, Feb 04 '14 at 09:48
@Shayanpourvatan i am storing the values in an arraylist....the last if else in the adapter — user2586942, Feb 04 '14 at 09:51
with this you add null to all your object, you need `textWatcher` or `focus listener` ( it's depend to your need ) and save value on that — Shayan Pourvatan, Feb 04 '14 at 09:52
@Shayanpourvatan i have tried that also...can u please give me some sample code... — user2586942, Feb 04 '14 at 09:58
can you post what you have tried? maybe with that we can better helped you, i don't have any sample — Shayan Pourvatan, Feb 04 '14 at 09:59
@Shayanpourvatan i have edited the code. Added the Text Changed Listener — user2586942, Feb 04 '14 at 10:14
my requirements are that i want to store the values in a database according to the position they are at in the list — user2586942, Feb 04 '14 at 10:16
and result same as before ? move your code on `afterTextChanged` to `onTextChanged` and set value with `arg0.toString();` — Shayan Pourvatan, Feb 04 '14 at 10:17
see http://stackoverflow.com/questions/8130257/android-multiple-edittext-fields-in-a-listadapter — Shayan Pourvatan, Feb 04 '14 at 10:44
another way is create own TextWatcher class, see http://stackoverflow.com/questions/5702771/how-to-use-single-textwatcher-for-multiple-edittexts/6172024#6172024 or http://stackoverflow.com/questions/8130257/android-multiple-edittext-fields-in-a-listadapter — Shayan Pourvatan, Feb 04 '14 at 10:51
@Shayanpourvatan even this doesnt work..still the values change... only now they do not change to the default value...but to the first digit i enter in the edit text in the first position — user2586942, Feb 04 '14 at 13:45

score 0 · Answer 1 · edited May 23 '17 at 12:28

0

the problem is all about relate to focus . see here , it may help you.

Focusable EditText inside ListView

edited May 23 '17 at 12:28

Community

1
1

answered Feb 04 '14 at 10:18

Waqar Ahmed

5,005
2
23
45

custom listview with edittext,checkbox and textview

1 Answers1

Linked