Regex.Replace not working

Question

I am having a strange issue with Regex.Replace

string test = "if the other party is in material breach of such contract and, after <span style=\"background-color:#ffff00;\">forty-five (45)</span> calendar days notice of such breach";
string final = Regex.Replace(test, "forty-five (45)", "forty-five (46)", RegexOptions.IgnoreCase);

the "final" string still shows "forty-five (45)". Any idea why? I am assuming it has to do something with the tag. How do I fix this?

Thanks

Did you really want to replace *forty-five (45)* with *forty-five (46)*? Looks like a typo. — Erik Philips, Feb 05 '14 at 00:36
I am assuming it is because of the special characters "(" and ")" — Mithil, Feb 05 '14 at 00:36
@ErikPhilips, this is just a test text. I know the text does not make sense but this is just a test scenario which is failing. — Mithil, Feb 05 '14 at 00:37
I tried String.Replace() and that fixed my issue. But I would still like to know how can I get it working with Regex. — Mithil, Feb 05 '14 at 00:43
Don't forget [the dangers of parsing html with regex](http://stackoverflow.com/a/1732454/781965) — Jeff, Feb 05 '14 at 01:19

PearsonArtPhoto · Answer 1 · 2014-02-05T00:51:39.213

6

Escape the parenthesis. Depending on the language, might require two back slashes.

string final = Regex.Replace(test, "forty-five \(45\)", "forty-five (46)", RegexOptions.IgnoreCase);

Basically, parenthesis are defined to mean something, and by escaping the characters, you are telling regex to use the parenthesis character, and not the meaning.

Better yet, why are you using a Regex to do this at all? Try just doing a normal string replacement.

string final = test.Replace("forty-five (45)", "forty-six (46)")

edited Feb 05 '14 at 00:51

answered Feb 05 '14 at 00:27

PearsonArtPhoto

38,970
17
111
142

1

I actually simplified the code for posting. The "search" and "replace" variables are dynamic. So I can't really escape anything. – Mithil Feb 05 '14 at 00:31
1

Why can't you escape ( and )? Those can be string replaced before regex replaced. – Erik Philips Feb 05 '14 at 00:37
@ErikPhilips the actual string might contain other special characters as well. So it won't be feasible to check on each special character. – Mithil Feb 05 '14 at 00:49
If that's the case, you probably want to do a replacement that doesn't involve regex. See my edit. – PearsonArtPhoto Feb 05 '14 at 00:52
It seems you don't have a clear understanding (or you haven't communicated it) of what your source and replacement values are. [Escaping special characters isn't that hard, I don't see the issue](http://stackoverflow.com/questions/399078/what-special-characters-must-be-escaped-in-regular-expressions). – Erik Philips Feb 05 '14 at 17:54

Nicholas Carey · Answer 2 · 2020-07-31T01:08:59.887

Parentheses are special in regular expressions. They delimit a group, to allow for things such as alternation. For example, the regular expression foo(bar|bat)baz matches:

foo, followed by
either bar OR bat, followed by
baz

So, a regular expression like foo(bar) will never match the literal string foo(bar). What it will match is the literal string foobar. Consequently, you need to escape the metacharacters. In C#, this should do you:

string final = Regex.Replace(test, @"forty-five \(45\)", "forty-five (46)", RegexOptions.IgnoreCase);

The @-quoted string helps avoid headaches from excessive backslashes. Without it, you'd have to write "forty-five \(45\)".

score 0 · Answer 3 · answered Feb 05 '14 at 01:08

0

If you are unable to escape the parenthesis, put them in a character class:

forty-five [(]45[)]

answered Feb 05 '14 at 01:08

Vasili Syrakis

9,321
1
39
56

Regex.Replace not working

3 Answers3