Is declaring a function variable required (in Javascript)?

Question

The teachers at my school are teaching us we have to specifically declare function variables like so:

function something(var1, var2)
{
    var var1, var2;
    console.log(var1);
    console.log(var2);
}

something("Totally", "Cool");

However I can't seem to find any topics about this, so my question is, is this even required? Isn't it perfectly normal and OK to just leave the var var1, var2; out?

If so, is this stated somewhere in the W3C JavaScript documentation?

I mean it works either way, but if it works without... Cleaner code I'd say :P

Code I'm talking about: http://pastebin.com/y5B2aznc

Thanks!

score 4 · Answer 1 · edited May 23 '17 at 12:11

in javascript, the scope of variables depends on how they are declared:

if you declare the variable when you define it, the scope of the variable is global
if you declare it using the var keyword, the scope of the variable is within the function
if you use the newer ES6 let keyword, the scope of the variable is within current block

so it is better to not use global variables and always limit the scope of your variables.

Here are a few references explaining the variable scopes in javascript:

you should also definitely read Douglas Crockford's Javascript, the good parts:

edit:

in your particular case, it is not useful:

function something(var1, var2)
{
    var var1, var2;
    console.log(var1);
    console.log(var2);
}

as you give those variables as parameters of the function, they are already declared within the function scope, so declaring them again as var is redundant, and you can safely remove that line.

function something(var1, var2)
{
    console.log(var1);
    console.log(var2);
}

NiGhTTraX · Answer 2 · 2014-02-07T10:56:00.473

If you don't use the var statement then the variables will be created in the global scope which is the window object. This is a bad practice since you're polluting the global scope and can affect other scripts/functions.

I suggest you read on the var statement on MDN. Also, here's a nice article on Javascript scope.

Edit: I didn't notice that the variables you're declaring are also the function parameters. In this case, the var statement will have no effect since re-declaring an already declared variable is a no-op (does nothing).

If you want to know more about the var statement and how scope is handled in Javascript, may I suggest reading this article?

That's not true in this case: the teacher is asking him to declare arguments using the `var` statement even though they're present in the function signature. — Andy E, Feb 07 '14 at 10:51

score 1 · Answer 3 · answered Feb 07 '14 at 10:50

1

Omitting the keyword var in the declaration will result in the variables being global and not having their scope limited to the function.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/var

answered Feb 07 '14 at 10:50

Stuart Miller

647
3
8

Nope. The variables mentioned are present as arguments on the function, so this isn't true. – Andy E Feb 07 '14 at 10:52
Yep, completely missed that one. – Stuart Miller Feb 07 '14 at 10:53

score 1 · Accepted Answer · answered Feb 07 '14 at 10:52

1

In your particular case, all the variables passed as arguments are local variables just like the variables you declare with var. So re-declaring them with var is redundant.

But a better practice is to leave the arguments with their original values, and do stuff with them storing the results in other local variables. E.g.:

function something(var1, var2)
{
    var varAlt1 = var1.toUpperCase(), varAlt2 = var2.toLowerCase();
    console.log(varAlt1);
    console.log(varAlt2);
}

answered Feb 07 '14 at 10:52

MaxArt

22,200
10
82
81

I think this is more like what my teachers want me to do. Weird thing is that PhpStorm (7.1.2) is saying one variable is redundant but the other isn't... – Alwyn Feb 07 '14 at 11:11

Is declaring a function variable required (in Javascript)?

4 Answers4