If statement not working as expected in checking input value

Question

Trying to get my if to either allow the user to input a name or randomly choose but no matter what is entered it goes to the input of name?

Any ideas?

Here is my snippet:

import random
import os
names = "Balo", "Bandugl", "Baroro", "Cag", "Charoth", "Dugling", "Dulko", "Fangot", "Gormath", "Varth", "Ugort", "Ogong", "Tuli", "Corg", "Chau", "Korg", "Salath", "Wegia",        "Wecha", "Moroth", "Kangir", "Bethindu", "Duak", "Fagoot", "Penam"
rand_name = random.choice(names)

#Character creation (1)#
if input("Would you like to choose a name?: ") == "Y" or "y" or "yes" or "YES":
    print("")
    c1 = {"Name":input("Name: ")}
else:
    c1 = {"Name":rand_name}
print(c1)

Thanks in advance!

Sorted changed my if to if input(... is IN a list of accepted answers variable :) — Aidan H, Feb 07 '14 at 12:49
@FallenAngel: the system won't let you spell "statement" correctly because a question with that title already exists so... just spell it incorrectly instead? — Wooble, Feb 07 '14 at 12:56

Mp0int · Accepted Answer · 2014-02-07T13:03:35.513

In your line

if input("Would you like to choose a name?: ") == "Y" or "y" or "yes" or "YES":

You can not chain values like that, it will evaluated as follows

( input("Would you like to choose a name?: ") == "Y") or ("y") or ("yes") or ("YES")

in which case, or ("y") will return True since non-empty strings are all evaluated True

You must try:

if input("Would you like to choose a name?: ") in ["Y", "y", "yes", "YES"]:

then it will check if input is one of "Y", "y", "yes" or "YES" values

Or you can use str.upper() to make your option list less crowded:

if input("Would you like to choose a name?: ").upper() in ["Y", "YES"]:

score 1 · Answer 2 · edited Feb 07 '14 at 12:50

1

if input("Would you like to choose a name?: ").lower() in ("y", "yes"):

edited Feb 07 '14 at 12:50

sloth

99,095
21
171
219

answered Feb 07 '14 at 12:50

Rich Tier

9,021
10
48
71

score 0 · Answer 3 · answered Feb 07 '14 at 12:50

0

You comparison is wrong.

if input("Would you like to choose a name?: ") in ("Y", "y", "yes", "YES"):

To understand your error:

>>> "a" == "Y" or "y"
'y'
>>> "Y" == "Y" or "y"
True

answered Feb 07 '14 at 12:50

iurisilvio

4,868
1
30
36

Abhilash Joseph · Answer 4 · 2014-02-07T13:13:08.140

Use raw_input(2.7) input in 3

import random
import os
names = "Balo", "Bandugl", "Baroro", "Cag", "Charoth", "Dugling", "Dulko", "Fangot", "Gormath", "Varth", "Ugort", "Ogong", "Tuli", "Corg", "Chau", "Korg", "Salath", "Wegia",        "Wecha", "Moroth", "Kangir", "Bethindu", "Duak", "Fagoot", "Penam"
rand_name = random.choice(names)

#Character creation (1)#
if raw_input('Enter your name: ').upper() in ["Y" , "YES" ]:
    print("")

    c1 = {"Name":raw_input("Name: ")}
else:
    c1 = {"Name":rand_name}
print(c1)

If statement not working as expected in checking input value

4 Answers4