Disposing Controls on Winforms

Question

Why does Visual Studio add this code to the Class.Designer.cs partial class. Can anyone tell me when this components variable is going to get some value? What's the pattern to follow here?

private System.ComponentModel.IContainer components = null;

        /// <summary>
        /// Clean up any resources being used.
        /// </summary>
        /// <param name="disposing">true if managed resources should be disposed; otherwise, false.</param>
        protected override void Dispose(bool disposing)
        {
            if(disposing && (components != null))
            {
                components.Dispose();
            }
            base.Dispose(disposing);
        }

score 7 · Answer 1 · answered Jan 29 '10 at 16:40

It is code that is produced by the Form item template (common7\ide\itemtemplates\csharp\windows forms\1033\form.zip\form.designer.cs). It actually has a bug, the InitializeComponent() method it contains initializes the "this.components" variable unnecessarily. You can safely delete the statement from the code if your form doesn't have any components. The designer will automatically put it back if you add a component later.

Another thing that is not so nice is that the Dispose() method is put in the Designer.cs file. It really belongs in the form.cs file so you can add Dispose() calls for fields in your form that should be disposed. Don't hesitate to move the code yourself, modifying the designer file this way doesn't have any unpleasant side-effects. Just stay away from the code that's bracketed with the "generated code" region.

As mentioned in most other answers, this code is necessary to call the Dispose() method of any components that you've dropped on the form when the form is closed. Controls on the form need to be disposed as well but that's automatic. The Form class finds them back by iterating the Controls collection.

"move to the my code (from designer)" is useful for me. Thanks! — antonio, Oct 02 '18 at 07:27

score 6 · Accepted Answer · edited May 23 '17 at 11:46

The private field components is used to track disposable components on your form. Try dragging in a Timer component, and you should see something like this in the designer generated code:

this.components = new System.ComponentModel.Container();
this.timer1 = new System.Windows.Forms.Timer(this.components);

The pattern displayed in the Dispose(bool) method is usually referred to as the disposable pattern. Basically, the pattern ensures that all of the tracked components will be disposed, even if you never call the Dispose method explicitly, in which case the base class of your form will call the Dispose method in its finalizer (during garbage collection).

score 2 · Answer 3 · answered Jan 29 '10 at 16:04

2

components gets assigned when you add non-visual components, which also need to be disposed in a determinisitc way (for more information, refer to the IDisposable pattern).

answered Jan 29 '10 at 16:04

Lucero

59,176
9
122
152

score 0 · Answer 4 · answered Jan 29 '10 at 16:14

0

Not all components use it though- eg a HelpProvider and EventLog. You can even comment it out in these cases. Sounds like a ms bodge to me.

answered Jan 29 '10 at 16:14

user243357

181
3

Heh, in a form without any disposable components, Resharper suggests to make the field `readonly` :) – Jørn Schou-Rode Jan 29 '10 at 16:16

Disposing Controls on Winforms

4 Answers4