if condition not working, while trying to compare values in array list. Android

Question

i am trying to pass some values in to a function and compare some values and get the array list.

calling the Collect function in Dbhand class.

        TextView result = (TextView) findViewById(R.id.textviewres);

        result.setText(dbhand.collect(
                getIntent().getExtras().getString("temple_type"), 
                getIntent().getExtras().getString("notemples"))
                );

collect() Function in dbhand class.

public String collect(String temptype, String limit){

    SQLiteDatabase ourDatabase = this.getWritableDatabase();
    String result="";
    String []column =new String[]{KEY_ID,KEY_TMPNAME,KEY_TMPTYPE,KEY_LATITUDE,KEY_LONGITUDE,KEY_IMGNAME,KEY_YEARBUILD,KEY_ADDRESS,KEY_CITY,KEY_EMAIL,KEY_WEB,KEY_TEL1,KEY_TEL2,KEY_DESCRI};
    Cursor c=ourDatabase.query("templ", column, null, null, null, null,null, limit);


    c.moveToFirst();
    int iKEY_ID = c.getColumnIndex(KEY_ID);
    int iKEY_TMPNAME= c.getColumnIndex(KEY_TMPNAME);
    int iKEY_TMPTYPE= c.getColumnIndex(KEY_TMPTYPE);

    for (c.moveToFirst();!c.isAfterLast();c.moveToNext()){

        if (c.getString(iKEY_TMPTYPE) == temptype){

    result = result+c.getString(iKEY_ID)+"\t\t"+c.getString(iKEY_TMPNAME)+"\t\t"+c.getString(iKEY_TMPTYPE)+" \n";
        }
    }

    return result;

}

i didn't get any error, since the if condition is not compared. it does not return any value.

can anyone help me to fix this plz.

`c.getString(iKEY_TMPTYPE)` and `temptype` is String ? then use `equalsIgnoreCase` instead of == — ρяσѕρєя K, Feb 11 '14 at 09:30
@PankajKumar. thanks for your advice. next time tell me what book to read. — Sathya Baman, Feb 11 '14 at 09:37
@user3234352 You will get too many resources on internet... no worry about books :) — Pankaj Kumar, Feb 11 '14 at 09:45

score 1 · Answer 1 · answered Feb 11 '14 at 09:44

1

This is the bad programming to compare two strings. You should use this.

c.getString(iKEY_TMPTYPE).equalsIgnoreCase(temptype)

answered Feb 11 '14 at 09:44

Piyush

18,895
5
32
63

score 0 · Accepted Answer · answered Feb 11 '14 at 09:31

0

Use .equals() function of String class to compare Strings.

Like, c.getString(iKEY_TMPTYPE).equals(temptype)

answered Feb 11 '14 at 09:31

user370305

108,599
23
164
151

score 0 · Answer 3 · answered Feb 11 '14 at 09:32

0

In your collect method use if (c.getString(iKEY_TMPTYPE).equals(temptype)){

answered Feb 11 '14 at 09:32

Saurabh Sharma

489
5
20

if condition not working, while trying to compare values in array list. Android

3 Answers3