clearTimeout not working in recursion function - javascript

Question

Here is the code I am using. When ticks becomes equal to 5 the recursion function should stop clearing the mainThread timeout. Anybody please help.

var mainThread;  
var ticks = 0;  
function tickTimer() {  
    clearTimeout(mainThread);  
    if (ticks >= 5) {  
        endGame();  
    }  
    else {  
        mainThread = setTimeout(function () {  
            ticks++;  
            tickTimer();  
        }, 1000);  
    }  
}

Let me know if any concerns. Thank you in advance.

You are decreasing the value of `ticks` yet expect the game to end if the value becomes larger or equal than 5. — UweB, Feb 12 '14 at 08:56
as @UweB mentioned, shouldn't the ```if``` condition be ```if ( ticks == 5 ) { endGame(); }``` because ```(ticks >= 5)``` will always return true? — Varinder, Feb 12 '14 at 08:58
Consider using [`setInterval`](http://stackoverflow.com/q/729921/7586) instead of calling `setTimeout` repeatedly. — Kobi, Feb 12 '14 at 08:59

score 4 · Answer 1 · answered Feb 12 '14 at 08:58

4

Try this instead:

function tickTimer() {       
    if (++ticks >= 5)  {
        clearInterval (mainThread); 
        endGame();  
    }  
} 

var  mainThread = setInterval(tickTimer, 1000);
var ticks = 0;

answered Feb 12 '14 at 08:58

loxxy

12,990
2
25
56

score 1 · Answer 2 · answered Feb 12 '14 at 08:56

Did you declare mainThread ? Like this

var mainThread = null;
function tickTimer() {  
    clearTimeout(mainThread);
    mainThread = null;  
    if (ticks >= 5) {  
        endGame();  
    }  
    else {  
        mainThread = setTimeout(function () {  
            ticks++;  
            tickTimer();  
        }, 1000);  
    }  
}

And ticks++ not ticks--

score 1 · Answer 3 · answered Feb 12 '14 at 09:01

1

Please try to replace ticks-- to ticks++

answered Feb 12 '14 at 09:01

Eddy

88
1
8

score 1 · Accepted Answer · answered Feb 12 '14 at 09:19

1

you can try this. all you need to do is clear interval every time tickTimer function is called.

var  mainThread = setInterval(tickTimer, 1000);
var ticks = 0;

function tickTimer() {       
    if (++ticks >= 5)  {
        clearInterval (mainThread); 
        endGame();  
    }  
}

answered Feb 12 '14 at 09:19

Sheelpriy

1,675
17
28

Great! Sheel. It worked. BTW loxxy has given the same type of answer. and is working. – Manish Gupta Feb 12 '14 at 09:23
@sheelpriy Adding your insight to someone's answer is wonderful. But always make an effort to give credits, if any. – loxxy Feb 12 '14 at 09:57

score 0 · Answer 5 · answered Feb 12 '14 at 08:58

I've think just send your timer as argument

function tickTimer(timer) {  
    timer && clearTimeout(timer);  
    if (ticks >= 5) {  
        endGame();  
    }  
    else {  
        var timer = setTimeout(function () {  
            ticks--;  
            tickTimer(timer);  
        }, 1000);  
    }  
}

Don't use global scope )))

score 0 · Answer 6 · answered Feb 12 '14 at 08:59

0

I thing you should Initialize variable ticks as the function is triggered.

answered Feb 12 '14 at 08:59

Rohit Nigam

708
8
23

clearTimeout not working in recursion function - javascript

6 Answers6