Object reference not set to an object instance :"c# char in array"

Question

The error i'm getting is in the title. It has something to do with the array and the for-loop i'm having. I'm trying to store letters from a textbox in a array and then in a session and then search trough those letters in a for-loop and check if the letters in the array is equal to another letter from a txtbox. well....hope some of you know what's wrong. (There is some norwegian letters in there, but don't worry about them) Here is the code from the error:

    Linje 30:     protected void btnSjekkOrd_Click(object sender, EventArgs e)
    Linje 31:     { 
    Linje 32:             for (int i=0; i < arrayOrd.Length; i++ )
    Linje 33:             {
    Linje 34:                 if (txtBokstavSjekk.Text.Length == arrayOrd[i])

Here's all the code:

 using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;

public partial class _Default : System.Web.UI.Page 
{
    //Session
    char [] arrayOrd;

    protected void Page_Load(object sender, EventArgs e)
    {
        if (Session["arrayOrd"] != null)
        {
           arrayOrd = (char[])Session["arrayOrd"];
        }
    }
    protected void Page_Unload(object sender, EventArgs e) 
    {
        Session["arrayOrd"] = arrayOrd;

    }

    protected void btnStart_Click(object sender, EventArgs e)
    {
       char[] arrayOrd = txtOrd.Text.ToCharArray();//Putter txtOrd i array
    }
    protected void btnSjekkOrd_Click(object sender, EventArgs e)
    { 
            for (int i=0; i <= arrayOrd.Length; i++ )
            {
                if (txtBokstavSjekk.Text.Length == arrayOrd[i])
                {
                    labRiktigBokstav.Text += arrayOrd[i];
                }
                else {
                    labFeilBokstaver.Text += "<b>" + arrayOrd[i] + "<b/>";
                }
            }


    }
}

possible duplicate of [What is a NullReferenceException and how do I fix it?](http://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-and-how-do-i-fix-it) — Selman Genç, Feb 15 '14 at 16:34
You should step through your code, it would help you understand what the messages mean. Also, if (txtBokstavSjekk.Text.Length == arrayOrd[i]) checks if the textbox has as many characters as the character stored in arrayOrd at index i, with an implicit conversion I'm not sure can work. I am unconvinced it is what you want to achieve. — Kheldar, Feb 16 '14 at 01:18

Steve · Accepted Answer · 2014-02-15T16:40:17.890

Inside the btnStart_Click you are declaring another copy of the array arrayOrd.
A copy local to the event handler that is no more accessible at the end of the event and then destroyed

Remove the declaration type char[] and your code will reference to the global variable

protected void btnStart_Click(object sender, EventArgs e)
{
   arrayOrd = txtOrd.Text.ToCharArray();//Putter txtOrd i array
}

However, your code is still weak, if the user press the button btnSjekkOrd before the start button the arrayOrd is still null and the error will raise again

protected void btnSjekkOrd_Click(object sender, EventArgs e)
{ 
    if(arrayOrd == null) return; // or message to press the start button

    for (int i=0; i <= arrayOrd.Length; i++ )
    ....

Object reference not set to an object instance :"c# char in array"

1 Answers1