Update MySQL query with PHP

Question

I am trying to overwrite the current data in MySQL to be able to update everything. I am new to this I don't see any errors with the below code:

PHP code:

<?php
// see if the form has been completed
if (isset($_POST['submit'])){
    $firstname = $_POST['firstname'];
    $surname = $_POST['surname'];

    if($firstname && $surname){
        // connect to the server
        include_once("php_includes/db_conx.php");

        // check if that user exist 
        $exists = mysql_query ("SELECT * FROM users WHERE firstname='$firstname'") or die ("the query could not be connected");
        if (mysql_num_rows ($exists) != 0) {
            // update the description in the database
            mysql_query("UPDATE firstname SET surname='$surname' WHERE firstname='$firstname'") or die ("update could not be applied");
            echo "successful";
        } else echo "the name does not edist";  
    } else echo "you need to enter both of the fields try again:";
}
?>

The error I get is

The query could not be connected

but I tried the query and it is fine.

HTML:

<html>
<head>
<title>update MySql form</title>
</head>
<body>

<div id="pageMiddle">  

    <form action="user1.php" method="POST">
        <div>
        <p>First Name: <input type="text" name="firstname" id="firstname" ></p>
        <p>Surname: <input type="text" name="surname" id="surname"></p>
        <p><input type="submit" name="submit" id="submit" value="Update Description"></p>
        </div>
    </form>

</body>
</html>

You should REALLY read this http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php?rq=1 — Fabio, Feb 16 '14 at 13:48
Is UPDATE query wrong I hate how people just look down on people i said I am new to this — user3311898, Feb 16 '14 at 13:53
Instead of `die ("the query could not be connected")` try `die (mysql_error())` — Shankar Narayana Damodaran, Feb 16 '14 at 13:55
Then you have a problem here `include_once("php_includes/db_conx.php");` See if the file is getting included .. post the contents of it in the question. — Shankar Narayana Damodaran, Feb 16 '14 at 14:01
I just done a internet connect 'mysql_connect ("localhost","root","pass123","worldoi5_social"); mysql_select_db ("test") or die ("couldnt connect to the database"); ' m @ShankarDamodaran — user3311898, Feb 16 '14 at 14:08
Just do `mysql_connect ("localhost","root","pass123");mysql_select_db('worldoi5_social');` and test your code again. — Shankar Narayana Damodaran, Feb 16 '14 at 14:15
I am not getting any where, I think i need to start all over with a different approach @ShankarDamodaran — user3311898, Feb 16 '14 at 14:20
Then you should start making use of [`PreparedStatements`](http://in1.php.net/pdo.prepared-statements) as `mysql_*` is deprecated of PHP 5.5.0 — Shankar Narayana Damodaran, Feb 16 '14 at 14:22

Megan Squire · Accepted Answer · 2014-02-16T13:59:03.993

0

Your table is called 'users' but you are running UPDATE on firstname. Change it to:

UPDATE users SET surname...

Then do

$exists = mysql_query ("SELECT * FROM users WHERE firstname='" . $firstname . "'")

in order to isolate whether you have value for that variable. I would recommend printing the query string for testing purposes.

edited Feb 16 '14 at 13:59

answered Feb 16 '14 at 13:53

Megan Squire

1,001
7
18

I am still getting the same result can someone please show a better way I don't mind starting all over – user3311898 Feb 16 '14 at 14:09

Update MySQL query with PHP

1 Answers1