Unable to replace in String java ?

Question

I am unable to replace part of the substring in my code ? I want to get rid of the unwanted characters but i still get the same output ?

String BusDetails = "ROUTE 3  &#151; CLEARBROOK-UFV GOLINE TO UFV" ;
System.out.println("BusDetails before"+BusDetails);
BusDetails.replaceAll("&#151;", "");
System.out.println("BusDetails After"+BusDetails);


// Output 
BusDetails before ROUTE 3  &#151; CLEARBROOK-UFV GOLINE TO UFV
BusDetails After ROUTE 3  &#151; CLEARBROOK-UFV GOLINE TO UFV

you need to *assign back* the output of `BusDetails.replaceAll("", "");` to `BusDetails` — Manish, Feb 20 '14 at 05:47
Side note: Make sure you stick to java naming conventions. Variables should start with a lowercase, and class names should start with an uppercase and be CamelCase. So `BusDetails` should be named `busDetails`. — mdewitt, Feb 20 '14 at 05:49

score 5 · Accepted Answer · answered Feb 20 '14 at 05:47

5

Java strings are immutable. You need to do this:

BusDetails = BusDetails.replaceAll("&#151;", "");

Also: "standard practice" is to name variables with a lowercase first letter busDetails.

answered Feb 20 '14 at 05:47

John3136

28,809
4
51
69

score 0 · Answer 2 · answered Feb 20 '14 at 05:47

0

BusDetails= BusDetails.replaceAll("&#151;", "");

you forgot to re assign variable

answered Feb 20 '14 at 05:47

Yogesh

4,546
2
32
41

score 0 · Answer 3 · answered Feb 20 '14 at 05:58

You need to put 'replaced value' into another variable. Example below compiled code:

String busDetails = "ROUTE 3  &#151; CLEARBROOK-UFV GOLINE TO UFV" ;
System.out.println("BusDetails before :"+busDetails);
String replacetxt = busDetails.replaceAll("&#151; ", "");
System.out.println("BusDetails After :"+replacetxt);

Unable to replace in String java ?

3 Answers3