Inserting profile in a linked list

Question

This code is for adding an employee profile at the beginning of a linked list. For some reason, which i cannot identify, this code worked once, and then it just printed the printf and then exited the loop. Even after entering numerous records, it was still doing the same thing. So can anyone identify the problem??

void insert_tobeg() {
    char name[15];
    struct employee *newPtr;
    printf("\n\n\tEnter the record to be entered:");
    gets(name);

    if(strcmp(start->name, name) == 0) {
        curr = (struct employee*)malloc(sizeof(struct employee));
        employee_entry();
        curr->newPtr = start;
        start = curr;
        printf("\n\n\tRecord has been added at the beggining!");
        return;
    }
}

It exited because there is no loop. Only one if statement – AndyFaizan Feb 23 '14 at 07:19 — AndyFaizan, Feb 23 '14 at 07:19

score 0 · Answer 1 · answered Feb 23 '14 at 06:57

0

Did you mean while loop instead if, and remove return statement.

answered Feb 23 '14 at 06:57

Mikl X

1,199
11
17

well, i tried using the while and removing the return statement, it still does nothing. – Bonzi Feb 23 '14 at 07:03

score 0 · Accepted Answer · edited May 23 '17 at 12:20

You manage it incorrect, you overwrite the name in first element, you need to write to the currently allocated ellement. Try something like this

curr = (struct employee*)malloc( sizeof(struct employee));
employee_entry();
if( strcmp( curr->name, name) == 0)
{
    curr->newPtr=start;
    start = curr;
    printf("\n\n\tRecord has been added at the beggining!");
    return;
}
else
{
    free(curr);
}

And don't cast malloc result in C

Inserting profile in a linked list

2 Answers2