JS countdown doesn't work

Question

This code is supposed to show a seconds countdown on an HTML page. But it does not work at all. What could be wrong? I kinda copied the code from a website, and just added few details.

function timer() {

    var now = new Date().getFullYear;
    var newdate = new Date("March, 19, 2014");

    var SecCount = (newdate - now) / 1000;
    SecCount = Math.round(SecCount);
    if (SecCount === 1) {document.getElementById("days").innerHTML= "يوم واحد"; }
    else if (SecCount === 2) {document.getElementById("days").innerHTML= "يومان"; }
    else if (SecCount > 2 && SecCount < 10) {document.getElementById("days").innerHTML = (SecCount + " أيام"); }
    else {document.getElementById("seconds").innerHTML = (SecCount + " يوم"); }

    setTimeout(timer,1000);
}

`Date().getFullYear` is the function literal. you need parenthesis to call the function thus `Date().getFullYear()` — Jay Harris, Feb 26 '14 at 04:32

score 0 · Answer 1 · answered Feb 26 '14 at 04:36

0

Do you call timer() function from somewhere in your code besides setTimeout. You need to call it to start executing and call setTimeout

answered Feb 26 '14 at 04:36

Vlad Bezden

83,883
25
248
179

score 0 · Accepted Answer · edited May 23 '17 at 11:57

0

assuming you want the full date that is now for the variable 'now', you should use Date.now. getFullYear will only return 2014 which will give you unexpected results. this solution is only if you want a count down till March 19 2014.

// var now = new Date().getFullYear
var now = Date.now();

the variable day count isn't in the form of days, it should be this instead

// convert the seconds into days
var DayCount = Math.round(SecCount / (3600 * 24));

did you call the function to start the timeout loop ?

timer();

jsfiddle

edited May 23 '17 at 11:57

Community

1
1

answered Feb 26 '14 at 05:00

Jay Harris

4,201
17
21

Thanks Jay! How can I make it calculate hours too? I mean 03/19/2014 10:00:00 for example. – AqeelAT Feb 26 '14 at 14:16
And how to set timezone. – AqeelAT Feb 26 '14 at 14:22
if you can't explicitly put that I the date function then just add 10 hours to ie `3600 * 10` – Jay Harris Feb 26 '14 at 20:46

score 0 · Answer 3 · answered Feb 26 '14 at 05:16

0

I wrote a litte fiddle which does the job.

to get the time left over the % operator is very useful!

answered Feb 26 '14 at 05:16

philipp

15,947
15
61
106

I was trying to do it to be like this website: http://ss-cal.com, will yours still work? – AqeelAT Feb 26 '14 at 14:10

JS countdown doesn't work

3 Answers3