Using $_GET for pagination, adding one to it

Question

So what i am doing is creating a pagination in one php file.

i'm using $_GET for this:

if ( $_GET["page"] === "3" ) echo 'href="#"';
else echo 'href=?page=' . $_GET["page"] + 1 . '"';

This code is used for making the side arrow's work

Pagination

when i am on ?page=3 the script echo's href"#" like expected, but when i am on every other page the script echos

1"

I have checked the script a few times and don't see any error's.

I think i am just doing something stupid, but I really don't know what.

I hope you want to help me!

`if ($_GET['page']=="3") { echo 'href="#"'; } else { echo 'href=?page='.$_GET['page'] + 1.'"'; }` — TestUser1, Feb 26 '14 at 11:18

score 3 · Answer 1 · answered Feb 26 '14 at 11:17

3

Your else is wrong with the quotes and you need the brackets around the +1:

else echo 'href=?page=' . $_GET["page"] + 1 . '"';
// should be
else echo 'href="?page='.( $_GET["page"] + 1 ).'"';
                ^

answered Feb 26 '14 at 11:17

Martijn

Woops, mistype when I was trying to fix it. But it still output's 1# – MrBlackDrag0nfly Feb 26 '14 at 11:21
Thanks very much! (Ayame__ too!) this worked! My way worked before though, which is pretty weird. But ok! Thanks guy's you made my day! – MrBlackDrag0nfly Feb 26 '14 at 11:26
I kinda ment this to be the answer lol. But Ayame__'s works too – Martijn Feb 26 '14 at 14:18
I've set Ayame__'s answer as the solution because it gives a brief overview what I did wrong, and is,in my opinion, better for other people that have this problem too. – MrBlackDrag0nfly Feb 27 '14 at 15:20

score 1 · Accepted Answer · answered Feb 26 '14 at 11:19

1

You're adding a string and an integer with "+" inside a concat with no parenthesis

change it to

if ( $_GET["page"] === "3" ) echo 'href="#"'; else echo 'href="?page=' . ($_GET["page"]+ 1) . '"';

answered Feb 26 '14 at 11:19

Ayame__

score 0 · Answer 3 · edited May 23 '17 at 10:26

0

Didn't use "===", if $_GET["page"] is int your code return false. And you forget one quote.

Try this :

echo 'href="'.( ($_GET["page"] == 3) ? '#' : '?page='.($_GET["page"]+1) ).'"';

edited May 23 '17 at 10:26

Community

answered Feb 26 '14 at 11:23

user2226755

Actually, there's no error in that in his code. $_GET variables are all strings, and in his code he compares to string 3 (`"3"`). Typechecking has no added value here, but it's no wrong – Martijn Feb 26 '14 at 11:30

3 Answers3