15

I have an angular form whose submit method is being hit twice, and I can't figure out why. I'm pretty new to Angular, so it's possible I'm overlooking something fairly simple...

Html:

<div ng-app="RegistrationApp" ng-controller="RegistrationController">
    <form name="accountForm" ng-submit="submitAccount($event, accountForm, account)"  novalidate>

        // inputs here...

        <button type="submit" class="btn btn-success pull-right" ng-disabled="accountForm.$invalid">Submit</button>
    </form>
</div>

Js:

var RegistrationApp = angular.module('RegistrationApp', []);

RegistrationApp.controller('RegistrationController', function ($scope) {

    $scope.submitAccount = function (evt, form, account) {
        console.log('submitAccount() hit'); 
        console.log(evt);
        console.log(form);

        evt.stopPropagation();

        // AJAX code
    });
});

Console Window:

submitAccount() hit 
o.Event {originalEvent: Event, type: "submit", isDefaultPrevented: function, timeStamp: 1394139847226, jQuery210012237170152366161: true…}
c {$error: Object, $name: "accountForm", $dirty: true, $pristine: false, $valid: true…}

submitAccount() hit 
o.Event {originalEvent: Event, type: "submit", isDefaultPrevented: function, timeStamp: 1394139847226, jQuery210012237170152366161: true…}
Constructor {$error: Object, $name: "accountForm", $dirty: true, $pristine: false, $valid: true…}

So, the first thing I tried was to stop propagating the event, but that doesn't have any real effect. After going through the event objects, they're seem identical. The only thing that differs is the 'form' object. The properties are the same, except that one shows that "c" and the other shows "Constructor".

Any ideas what could be causing this to trigger twice? The event target is set to the form element in both cases, and I'm not using any onclick functions, or any other sorts of events in the form.

Brian Tompsett - 汤莱恩
  • 5,753
  • 72
  • 57
  • 129
Logan Black
  • 567
  • 3
  • 10
  • 21

6 Answers6

13

Another reason for this occurring (which just happened to me):

I had the following:

<form ng-submit="myCtrl.search()">
   <button type="submit">Search</button>
   <button type="submit" class="mobile-only" ng-click="myCtrl.search()">Go</button>
</form>

I had another button inside the form that was bound to the same function as the ng-submit on its ng-click which was causing the method to be called twice.

sma
  • 9,449
  • 8
  • 51
  • 80
12

Check you didn't declare your controller twice: one in the HTML, as I can see above, and another when configuring your routes. If it's the case, the controller is instanciated twice, so the listener is invoked twice

Pascal Le Merrer
  • 5,883
  • 20
  • 35
  • Right now I'm not configuring any routes. This is just a single page at this time, so what you see up there is really all I have. – Logan Black Mar 06 '14 at 21:29
  • Belay that, I was actually loading my App.js twice, so it was duplicating controllers. – Logan Black Mar 06 '14 at 21:31
  • 3
    Just if anyone has this same issue. I was putting (ngSubmit)="submit(true)" on the form tag and also (click)="submit()" on the button. Thank you. – Andres Baena May 07 '19 at 04:01
7

One reason happend to me, I'm not sure if this will happen to any other :)

In my controller I had:

$scope.submit = function() { someThingHere };

In the view

<form ng-submit="submit()">
</form>

This way that form has been submitted "mysteriously" two times, to solve that I had to rename $scope.submit to something else.

Walid Ammar
  • 4,038
  • 3
  • 25
  • 48
7

There are multiple causes for such behaivour (some of them noted already):

  • Declaring the controller twice (Check routes, html header, container html (if there is one).
  • Naming a function submit (Even if i could not reproduce it).
  • Set a ng-click function on the submit button when you have it already on the form ng-submit, just remove the ng-click. Clicking on the submit button or pressing enter on a input will call the ng-submit function by itself.

Double check them since it's easy to pass them by in some cases

Leo Armentano
  • 111
  • 1
  • 4
  • 3
    The 3rd one was a solution for me. Thanks, slipped my eyes somehow. – Skrew May 17 '17 at 14:06
  • The 3rd one was a solution for me too! – Xavi Torrens Aug 11 '17 at 09:44
  • 1
    I can reproduce 2 with `@Output() submit: EventEmitter` – Simon Warta Jan 12 '18 at 13:15
  • Event can be received twice also if it's called "search" : `@Output() search: EventEmitter`. Then parent component can receive your emitted event and native search event https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/search_event Renaming the eventEmmiter helps in this case. – Vincente Oct 22 '21 at 18:23
0

In my case, it was "ng-app" directive which I was not relying on as I manually bootstrap everything.

et3rnal
  • 322
  • 4
  • 17
0

I experienced this in Angular 12 with a reactive form because I had an unnecessary ngForm attribute on the form declaration:

  <form ngForm [formGroup]="formGroup" (ngSubmit)="onSubmit()">

Removing the attribute fixed the problem.

Chris Peacock
  • 4,107
  • 3
  • 26
  • 24