Part of my code isn't accessed nor executed

Question

A part of my form Load Event is neither accessed (breakpoint is not executed) nor executed (message box not showing), this is my code

private void Form1_Load(object sender, EventArgs e)
    {
        OpenFileDialog ofd = new OpenFileDialog();
        ofd.Title = "Open .ODI file";
        ofd.Filter = "ODI Files (*.odi)|*odi";
        DialogResult result = ofd.ShowDialog();
        if (result == DialogResult.Cancel)
            return;
        MessageBox.Show("bla");
        FileStream fs = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read);
        FileStream fs1 = new FileStream(Path.GetDirectoryName(ofd.FileName) + "\\VOL1.DAT", FileMode.Open, FileAccess.Read);
        //------------------------CODE IS NOT EXECUTED AFTER THIS
        MessageBox.Show("bla2");
        //getting the Main Folders
        byte[] fldrn = new byte[4]; 
        fs.Position = 0x74;
        fs.Read(fldrn, 0, 4);
        int fldrnum = BitConverter.ToInt32(fldrn, 0);
        MessageBox.Show(fldrnum.ToString(), "1");

        byte[] namaes = new byte[28];
        foldernames = new string[fldrnum];
        for (int i = 0; i < fldrnum; i++)
        {
            fs.Position = 0x88 + i*4;
            fs.Position = 0x74;
            fs.Read(fldrn, 0, 4);
            int fldrnam = BitConverter.ToInt32(fldrn, 0);
            int pos = (int)fs.Position;

            fs.Position = pos + fldrnam;
            fs.Read(namaes, 0, 28);
            foldernames[i] = Encoding.ASCII.GetString(namaes).Split('\0')[0];
            MessageBox.Show(foldernames[i], i.ToString());
            treeView1.Nodes[0].Nodes[0].Nodes.Add(foldernames[i]).ImageIndex = 1;
        }
    }

@cHao it's a new project this was my first time debugging, so i think it auto genrates it no ? — Omarrrio, Mar 07 '14 at 22:09
Did you run this code on a 64bit system? Are you sure the file VOL1.DAT exists in the specified folder? — Steve, Mar 07 '14 at 22:10
youre using which IDE.. and ys it automatically generate that code in the desingner side.. — rummykhan, Mar 07 '14 at 22:10
@Steve it does exist, it would have thrown an exception if it wasn't — Omarrrio, Mar 07 '14 at 22:10
No Form.Load event and exceptions on 64bit system doesn't work very well togheter — Steve, Mar 07 '14 at 22:11
and does form loads.. without executing ur code.. or it does not load — rummykhan, Mar 07 '14 at 22:11
Does it block on opening your FileStream? Or does your application close? Or do you supress any exceptions in the UnHandledExceptionEventHandler? — Silvermind, Mar 07 '14 at 22:12
@Silvermind there is one thing i found weird, usually when debugging the debugged application comes on top of my VS window, but this one just starts minimized — Omarrrio, Mar 07 '14 at 22:13
Try your code without using VIsual Studio and see if throws an exception — Steve, Mar 07 '14 at 22:15
i removed the second FileStream and now it works, but this si weird, the file exists, why would it not execute ? — Omarrrio, Mar 07 '14 at 22:16
u can change the file position to D:\\vol.dat and than try.. u will b sure.. this is my practice.. — rummykhan, Mar 07 '14 at 22:19
ooh it's not in the same directory AS the exe, obviously im getting it from another directory. — Omarrrio, Mar 07 '14 at 22:22
Can you tell me why you are trying to open a file (fs1) that you don't use anywhere in the remainder of the code above? What is the name of the file opened using ofd.Filename? — Steve, Mar 07 '14 at 22:25
ok, i'll explain everything, so the fs opened files is a bunch of information, that i will use to extract files from fs1 opened file, fs1 is opening a package of files. — Omarrrio, Mar 07 '14 at 22:27
Problem solved, seems that if the file was already opened somewhere else(in mad edit), it stops the execution(???) of the code after FileStreaming that file. — Omarrrio, Mar 07 '14 at 22:28
If you had listened and tryed to execute your program outside of VS2010 you have seen your exception.http://stackoverflow.com/questions/4933958/vs2010-does-not-show-unhandled-exception-message-in-a-winforms-application-on-a/4934010#4934010 — Steve, Mar 07 '14 at 22:29
Thank you guys,@Steve put the solution so i can check it, also is there anyway to bypass this stupid limit ? — Omarrrio, Mar 07 '14 at 22:30
It is a duplicate then, try to move your code in the form constructor if possible. (or in the Form_Shown event) — Steve, Mar 07 '14 at 22:32
I think you could add an answer by yourself, explaining what happen and how you have resolved the problem. Put a link to the answer from Mr HansPassant and finally accept it to close the question. See you again on SO. — Steve, Mar 07 '14 at 22:42

score 1 · Answer 1 · answered Mar 07 '14 at 22:08

1

Do you have something like this in your constructor? Would be best to have this in the designer file if it is windows forms.

this.Load += new EventHandler( Form1_Load);

answered Mar 07 '14 at 22:08

DROP TABLE users

1,955
14
26

1

i think thix is a window form app.. so that code must b generated in designer class.. – rummykhan Mar 07 '14 at 22:10
@rummykhan that would be the best place for it to be but it wold work in a constructor. I was just trying to identify if attaching the event was the problem. – DROP TABLE users Mar 07 '14 at 22:10
2

@Omarrrio: For future reference, pictures of code are next to useless for most purposes. Most people would very much prefer if you post code on a site like http://pastebin.com or http://ideone.com (or, even better, if you simply add it to the question so future visitors don't have to ask about it again). – cHao Mar 07 '14 at 22:47
1

@cHao, thank you and sorry, i won't let it happen again. – Omarrrio Mar 07 '14 at 22:54

score 1 · Answer 2 · answered Mar 07 '14 at 22:17

private void Form1_Load(object sender, EventArgs e)
    {
        OpenFileDialog ofd = new OpenFileDialog();
        ofd.Title = "Open .ODI file";
        ofd.Filter = "ODI Files (*.odi)|*odi";
        DialogResult result = ofd.ShowDialog();
        if (result == DialogResult.Cancel)
            //return;   jux remove this return and ur code will work fine
            // actually we dont use return in the body of if condition.. bad practice

        MessageBox.Show("bla");
        FileStream fs = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read);
        FileStream fs1 = new FileStream(Path.GetDirectoryName(ofd.FileName) + "\\VOL1.DAT", FileMode.Open, FileAccess.Read);
        //------------------------CODE IS NOT EXECUTED AFTER THIS
        MessageBox.Show("bla2");
        //getting the Main Folders
        byte[] fldrn = new byte[4]; 
        fs.Position = 0x74;
        fs.Read(fldrn, 0, 4);
        int fldrnum = BitConverter.ToInt32(fldrn, 0);
        MessageBox.Show(fldrnum.ToString(), "1");

        byte[] namaes = new byte[28];
        foldernames = new string[fldrnum];
        for (int i = 0; i < fldrnum; i++)
        {
            fs.Position = 0x88 + i*4;
            fs.Position = 0x74;
            fs.Read(fldrn, 0, 4);
            int fldrnam = BitConverter.ToInt32(fldrn, 0);
            int pos = (int)fs.Position;

            fs.Position = pos + fldrnam;
            fs.Read(namaes, 0, 28);
            foldernames[i] = Encoding.ASCII.GetString(namaes).Split('\0')[0];
            MessageBox.Show(foldernames[i], i.ToString());
            treeView1.Nodes[0].Nodes[0].Nodes.Add(foldernames[i]).ImageIndex = 1;
        }
    }

it still doesn't work, but when i remove the fs1 filestream, it works — Omarrrio, Mar 07 '14 at 22:19
_actually we dont use return in the body of if condition.. bad practice_ That is ridiculous. — Silvermind, Mar 07 '14 at 22:20
well it's not bad practice, it makes sure the code is NOT executed if the cancel button is pressed — Omarrrio, Mar 07 '14 at 22:23
Of course you understand that I mean that it is ridiculous to say that it is bad practice. It is just an eager return. Put it between braces and it is clear as day what is happening. — Silvermind, Mar 07 '14 at 22:24

score 1 · Accepted Answer · edited May 23 '17 at 11:49

1

I found the answer, i was accessing a file already in use by one of my windows processes(fs1), it didn't throw an exception though, this is by far explained in this answer: VS2010 does not show unhandled exception message in a WinForms Application on a 64-bit version of Windows

edited May 23 '17 at 11:49

Community

1
1

answered Mar 07 '14 at 22:53

Omarrrio

1,075
1
16
34

Part of my code isn't accessed nor executed

3 Answers3