How to download a file from specific directory using php header

Question

I have some code to download file using php header but it is not properly working and want to add directory to read

    <?php
if(isset($_GET['link'])){
    $var_1 = $_GET['link'];
$dir='/upload/';
}
?>
<?php
if(isset($_GET['link'])){
    $var_1 = $_GET['link'];
$file = $var_1;
if (file_exists($file)) {
    header('Content-Description: File Transfer');
    header('Content-Type: application/octet-stream');
    header('Content-Disposition: attachment; filename='.basename($file));
    header('Expires: 0');
    header('Cache-Control: must-revalidate');
    header('Pragma: public');
    header('Content-Length: ' . filesize($file));
    ob_clean();
    flush();
    readfile($file);
    exit;
}
echo "<h1>Content error</h1><p>The file does not exist!</p>";
}
?>

It shows error Content error

The file does not exist!

I am Using

http://sap.layyah.info/download.php?link=UAC.dll

this link to download the file file original location is

http://sap.layyah.info/upload/UAC.dll

it shows Parse error: syntax error, unexpected $end in /home/u723533513/public_html/download.php on line 19 — user2740125, Mar 08 '14 at 05:27
We need to know how you're using this, from a form? A hyperlink? Plus, what do you mean by "add a directory to read"? — Funk Forty Niner, Mar 08 '14 at 05:33
You shouldn't follow the comments/examples from php.net regarding readfile() which is exactly where that came from. There are many other better examples out there. I personally use the XSendFile header using apache. — ElefantPhace, Mar 08 '14 at 05:35
i am using it like hyper link and my location of files are different then download.php — user2740125, Mar 08 '14 at 05:36
This `$file = $var_1;` could be something like `$dir="folder/"; $file = $dir$var_1;` or `$dir="../folder/"; $file = $dir$var_1;` depending on the folder's location. — Funk Forty Niner, Mar 08 '14 at 05:38
Doh! lol You're right, I forgot the dot `$file = $dir . $var_1;` @ElefantPhace Thanks (*Tired eyes*). I will rephrase for the OP. — Funk Forty Niner, Mar 08 '14 at 05:44
This `$file = $var_1;` could be something like `$dir="folder/"; $file = $dir . $var_1;` or `$dir="../folder/"; $file = $dir . $var_1;` depending on the folder's location. — Funk Forty Niner, Mar 08 '14 at 05:47
See my answer and also look for a working test under my **Edit** @user2740125 — Funk Forty Niner, Mar 08 '14 at 06:18

score 13 · Accepted Answer · edited Jun 20 '20 at 09:12

First, the quotes in $file = '$var_1'; won't get interpreted correctly,

therefore it needs to read as $file = $var_1;

You also have a missing closing brace }

<?php
if(isset($_GET['link']))
{
    $var_1 = $_GET['link'];
    $file = $var_1;

if (file_exists($file))
    {
    header('Content-Description: File Transfer');
    header('Content-Type: application/octet-stream');
    header('Content-Disposition: attachment; filename='.basename($file));
    header('Expires: 0');
    header('Cache-Control: must-revalidate');
    header('Pragma: public');
    header('Content-Length: ' . filesize($file));
    ob_clean();
    flush();
    readfile($file);
    exit;
    }
} //- the missing closing brace
?>

And you mentioned that you wanted to use a different folder.

You could use something to the effect of:

$dir = "folder/"; // trailing slash is important
$file = $dir . $var_1;

or

$dir = "../folder/"; // trailing slash is important
$file = $dir . $var_1;

depending on the folder's location.

Edit

The following is tested and worked for me and the files were run from the root of my server.

<?php
if(isset($_GET['link']))
{
    $var_1 = $_GET['link'];
//    $file = $var_1;

$dir = "folder/"; // trailing slash is important
$file = $dir . $var_1;

if (file_exists($file))
    {
    header('Content-Description: File Transfer');
    header('Content-Type: application/octet-stream');
    header('Content-Disposition: attachment; filename='.basename($file));
    header('Expires: 0');
    header('Cache-Control: must-revalidate');
    header('Pragma: public');
    header('Content-Length: ' . filesize($file));
    ob_clean();
    flush();
    readfile($file);
    exit;
    }
} //- the missing closing brace
?>

HTML (I used a PDF file as an example)

<a href="download.php?link=document.pdf">Download here</a>

That's great news, glad to hear it. @user2740125 Glad to have helped. — Funk Forty Niner, Mar 08 '14 at 06:20

How to download a file from specific directory using php header

1 Answers1

Edit

Linked