Saving Text to array

Question

I have been using this link as an example, but have been having troubles with it: 2d Array from text file c#

I have a textfile that contains :

And I'm trying to use the function:

static void Training_Pattern_Coords()
{
    String input = File.ReadAllText(@"C:\Left.txt");

    int i = 0, j = 0;
    int[,] result = new int[4, 4];
    foreach (var row in input.Split('\n'))
    {
        j = 0;
        foreach (var col in row.Trim().Split(' '))
        {
            result[i, j] = int.Parse(col.Trim());
            j++;
        }
        i++;      
    }
    Console.WriteLine(result[1, 3]);

    Console.ReadLine();
}

However I keep getting the error message (Input String was not in correct format) at the line :

foreach (var row in input.Split('\n'))

I think it has something to do with the spaces within the textfile but I'm not entirely sure. Thanks for your help!

sorry the text file is a 4x4 array with spaces between them but it has come up as one line in the question: — user3365114, Mar 13 '14 at 18:01
http://ericlippert.com/2014/03/05/how-to-debug-small-programs/ — Samuel, Mar 13 '14 at 18:03
The lines are most probably separated by `\r\n` (carriage return / line feed). — Olivier Jacot-Descombes, Mar 13 '14 at 18:12
Just tried the same and it works. Your lines are not exactly separated by `\n` rather `\r\n` — Rahul, Mar 13 '14 at 18:14

Selman Genç · Accepted Answer · 2014-03-13T18:17:15.687

2

Instead of File.ReadAllText use File.ReadLines.By doing that you won't need to use Split('\n').

int[,] result = new int[4, 4];

var lines = File.ReadLines(@"C:\Left.txt")
               .Select(x => x.Split()).ToList();
for (int i = 0; i < 4; i++)
{
    for (int j = 0; j < 4; j++)
    {
        result[i, j] = int.Parse(lines[i][j]);
    }
}

edited Mar 13 '14 at 18:17

answered Mar 13 '14 at 18:03

Selman Genç

100,147
13
119
184

1

He should use `ReadLines` over `ReadAllLines`, given that he's only ever `foreach`ing over it, for the sake of the reduced memory overhead. – Servy Mar 13 '14 at 18:05

score 1 · Answer 2 · answered Mar 13 '14 at 18:10

1

Try ReadAllLines as opposed to ReadAllText

answered Mar 13 '14 at 18:10

MrM

21,709
30
113
139

Rahul · Answer 3 · 2014-03-13T18:34:23.317

0

Replace any \r (carriage return)

input = input.Replace('\r',' ');

edited Mar 13 '14 at 18:34

answered Mar 13 '14 at 18:21

Rahul

76,197
13
71
125

score 0 · Answer 4 · answered Mar 13 '14 at 18:49

0

Replace your \r to "\r\n"

Try this:

foreach (var row in input.Split("\r\n"))

answered Mar 13 '14 at 18:49

f.fujihara

101
1

Saving Text to array

4 Answers4