Display Error If User Input Higher Than Number Of Available Records (Script Update)

Question

Allende wrote this for me in answer to an earlier question and I'm trying to figure out how I add an extra piece of code, so that if the user enters a number higher than the total number of records, it throws up an error. I know I can use SQL RecordCount to find the number of records, but I have no idea how to integrate it into Allende's script. As with the script, the error doesn't need to show until the form is submitted.

$(document).ready(function(){           
 $('form').on("submit",function(){
         var tempArray=[];            
         var exists=0;
         $("input[type='text'][name^='PositionNumber']").each(function(){
             exists = tempArray.indexOf($(this).val());             
             if (exists>=0){                    
                 return false;//break the loop
             }
             tempArray.push($(this).val());                  
         });

         //after you can use "exist" to check if duplicated and retrieve the value to cancel the submit
         if (exists>=0){                   
             alert("You have used the number " + tempArray[exists] +" more than once.\r\nPlease correct the error and resubmit.");                
         } else{
             //alert("no duplicated value:");
             return true;
         }

        return false;            
 }); 
});

Thanks in advance for the help and advice.

Regards

Pb

Answer 1

Yes, one option would be to have another hidden field and modify your jquery, but a more elegant solution would be to make it impossible to enter an invalid value in the first place. Instead of having a text field to input the position you could have a select which only goes up to the number of records.

The ASP would look like this

<select name="positionnumber">
<% 
For i = 1 To rsmenulist.recordcount 
  response.write "<option>" & i & "</option>"
Next
%>
</select>

clent side this would look like

<select>
<option>1</option>
<option>2</option>
<option>3</option>
<option>4</option>
</select>

(assuming of course there were 4 records.

If you wanted the current value to show as selected when the page loads you could modify it as follows.

<select name="positionnumber">
<%     
For i = 1 To rsmenulist.recordcount 
if i = cint(rsmenulist("recordposition")) then 
 selected = " selected" 
else
 selected = ""
end if
  response.write "<option" & selected & ">" & i & "</option>"
Next
%>
</select>

You've clearly been using Dreamweaver to write your asp code. At the end of the day it works, which is the main thing, but DW produces very bloated code, and when you need to do something for which DW doesn't have a wizard working out where to put your own modifications can be a nightmare If you have time (which I realise can be a problem) then it's worth finding a good tutorial, you'll discover how to do in 2 lines what DW does in 20+.

One thing which DW typically does is to close one code block (with "%>") and then open another one on the following line "<%" with no client side code in between. If you want to be nice to your webserver then it's worth merging those into a single code block. I'm particularly talking about the section at the end of the page where you close all your recordsets

Answer 2

Here's the SQL code that gets the records for the form:

SELECT tblContent.*, tblMainMenu.MainMenuName, tblSubMenu.SubMenuName, tblSubMenu.SubMenuID
FROM (tblContent LEFT JOIN tblMainMenu ON tblContent.MainMenuID = tblMainMenu.MainMenuID) LEFT JOIN tblSubMenu ON tblContent.SubMenuID = tblSubMenu.SubMenuID
WHERE tblContent.SubMenuID = smID AND tblContent.DisplayRecord =1
ORDER BY tblContent.PositionNumber

Here's the code that displays it on the page (with John's code added):

<% IF Request.ServerVariables("QUERY_STRING") <> "" THEN %>
<h3><span style="font-size:small">Order/Re-order records for: </span><%=(rsContent.Fields.Item("SubMenuName").Value)%></h3>
<form action="record-order-modify.asp" method="post" class="recordPosition">
<%=rsRecordCount.RecordCount %>
<% 
While ((rptContent__numRows <> 0) AND (NOT rsContent.EOF)) 
%>
  <table width="100%" id="records">
    <tr>
      <td align="left" valign="top" name="ContentTitle" colspan="2"><h2><%=(rsContent.Fields.Item("ContentTitle").Value)%></h2><input type="hidden" value="<%=(rsContent.Fields.Item("ContentID").Value)%>" name="ContentID<%=counter%>">
      <%=(rsContent.Fields.Item("ContentData").Value)%>...
      </td>
      </tr>
      <tr>
      <td width="240"><label>Current Record Position:</label>&nbsp;&nbsp;<input type="text" class="recordPosition" value="<%=(rsContent.Fields.Item("PositionNumber").Value)%>"></td>
      <td align="right"><label>New Position: <small class="brown" style="text-transform:none">(You may change it here)</small></label>&nbsp;&nbsp;
        <select name="PositionNumber" class="recordPosition">
        <% 
        For i = 1 To rsContent.RecordCount 
        Response.Write "<option>" & i & "</option>"
        Next
        %>
        </select>
      </td>
     </tr>
  </table>
  <hr>
  <% 
  rptContent__index=rptContent__index+1
  rptContent__numRows=rptContent__numRows-1
  rsContent.MoveNext()
Wend
%>
<table align="center" class="positionButtons">
<tr>
<td width="50%" align="right"><input name="Submit" type="submit" value="Update Positions"></td>
<td width="50%" align="left"><input name="Reset" type="reset" value="Reset All Changes" tabindex="<%=counter%>"></td>
</tr>
</table>
<input type="hidden" name="action" value="update">
<input type="hidden" name="counter" value="<%=counter%>">
</form>
<% ELSE %>
<h3>Select a listing to order/re-order using the list on the left.</h3>
<% END IF %>