Show values from database and update with loop

Question

last time I ask how to save a loop to a database now want to show the values inside the table and then update it but it only saves the last row.

$id = ($_REQUEST['StudentNumber']);
$result2= mysql_query("select NameofSiblings, Age, HEA, CivilStatus, Occupation FROM $tblname WHERE StudentNumber='$id'");

$child = $_REQUEST['NumberofChildren'];
for($n=1;$n<=$child;$n++)
{
    while($row=mysql_fetch_array($result2))
    {

        echo "<table>
        <tr>

        <td class='siblings'><input type='text' name='sibname[]' style='width: 150px;' value=".$row['NameofSiblings']."></td>
        <td class='siblings'><input type='text' name='sibage[]' style='width: 35px;' value=".$row['Age']."></td>
        <td class='siblings'><input type='text' name='sibhea[]' style='width: 260px;' value=".$row['HEA']."></td>
        <td class='siblings'><input type='text' name='sibcs[]' style='width: 100px;' value=".$row['CivilStatus']."></td>
        <td class='siblings'><input type='text' name='siboccu[]' style='width: 100px;' value=".$row['Occupation']."></td>
        </tr>       
        </table>";
    }
}
?>
<input type="hidden" name="n" value="<?php echo $child; ?>">

Am I doing it right? And this is my update query:

$n=intval($_POST['n']);
for($i=0;$i<$n;$i++)
{
    $sibname =$_POST['sibname'][$i];
    $sibage =$_POST['sibage'][$i];
    $sibhea =$_POST['sibhea'][$i];
    $sibcs =$_POST['sibcs'][$i];
    $siboccu =$_POST['siboccu'][$i];

    $query = "UPDATE $tblname SET NameofSiblings = '$sibname', Age = '$sibage', HEA = '$sibhea', CivilStatus = '$sibcs', Occupation = '$siboccu' WHERE StudentNumber='$sn' ";
}

I hope someone can understand it.

Within your `for` loop you need to execute the query, not outside it or else it will use the last loops values. — SamV, Mar 15 '14 at 15:20
can you give my an example how to do it?.sorry i just started learning php — user3397568, Mar 16 '14 at 03:52

score 0 · Answer 1 · edited May 23 '17 at 12:13

0

When you loop through the POST values, you create a SQL query string yet you don't execute it (ie call mysql_query) within the loop (or outside it for that matter). You need to execute the query before the next iteration of the loop occurs or you will lose the value.

for ($i=0; $i<$n; $i++) {
    $sibname =$_POST['sibname'][$i];
    $sibage =$_POST['sibage'][$i];
    $sibhea =$_POST['sibhea'][$i];
    $sibcs =$_POST['sibcs'][$i];
    $siboccu =$_POST['siboccu'][$i];

    $query = "UPDATE $tblname SET NameofSiblings = '$sibname', Age = '$sibage', HEA = '$sibhea', CivilStatus = '$sibcs', Occupation = '$siboccu' WHERE StudentNumber='$sn' ";

    mysql_query($query); // execute query here for each iteration of the loop
}

Hope that makes sense, you should stop using the mysql_* functions as they are deprecated now and are very vulnerable to SQL injection attacks.

Take a look at these links, which should help a lot.

edited May 23 '17 at 12:13

Community

1
1

answered Mar 16 '14 at 09:11

SamV

7,548
4
39
50

i tried that but now it won't save the values on the DB. – user3397568 Mar 16 '14 at 12:19
@user3397568 At least update your code to reflect its current state or else I can't help... – SamV Mar 16 '14 at 12:22
ok.now it's working again..I put mysql_query($query); inside the loop but it's still save the last value. – user3397568 Mar 16 '14 at 13:15
did i put while($row=mysql_fetch_array($result2)) correctly after for loop? – user3397568 Mar 17 '14 at 10:29

Show values from database and update with loop

1 Answers1