I keep getting "You have an error in your SQL syntax" and the SQL works if run directly

Question

I keep getting "You have an error in your SQL syntax", event if the query runs ok by it's own.

The code :

function CreateUser(){
$token = md5(uniqid(rand(),true));
$query = "USE carshop;
INSERT IGNORE INTO users VALUES(
    '',
    '$GLOBALS[nume]',
    '$GLOBALS[pren]',
    '$GLOBALS[mail]',
    '$GLOBALS[adresa]',
    '$GLOBALS[parola]',
    '$token',
    '0',
    '0',
    '');";
echo $query;
mysql_query($query)or die("Error: ".mysql_error());
break;

}

Echo query : INSERT IGNORE INTO users VALUES( '', 'test1', 'test2', 'dididid@dd.com', 'dsads llaowd sda', '6ccee2f5b01591f6644036c1114b5b4f', '8b3cc272280f13d765b271e203124308', '0', '0', '');

And the DB structure is :

CREATE TABLE users (
`ID` INT(11) NOT NULL AUTO_INCREMENT,
`nume` CHAR(20) NOT NULL DEFAULT '0' COLLATE 'utf8_unicode_ci',
`prenume` CHAR(20) NOT NULL COLLATE 'utf8_unicode_ci',
`mail` VARCHAR(30) NOT NULL DEFAULT '0' COLLATE 'utf8_unicode_ci',
`adresa` TEXT NOT NULL DEFAULT '0' COLLATE 'utf8_unicode_ci',
`parola` VARCHAR(100) NOT NULL DEFAULT '0' COLLATE 'utf8_unicode_ci',
`token` VARCHAR(100) NOT NULL DEFAULT '0' COLLATE 'utf8_unicode_ci',
`isVerified` INT(1) NOT NULL DEFAULT '0',
`isOnline` INT(1) NOT NULL DEFAULT '0',
`dateCreated` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

)

Thanks, and sorry if i'm doing any newbie mistakes, i'm new at this

Should be using mysqli rather than mysql as it is deprecated and will be removed in future. — Cjmarkham, Mar 16 '14 at 19:30
Relevant reading: [avoid the dinosaurs](http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php/12860046#12860046), [don't feed the bears](http://stackoverflow.com/a/60496/2864740) — user2864740, Mar 16 '14 at 19:32
Please accept an answer, don't modify the question leaving it unanswered. — AD7six, Mar 16 '14 at 20:21

score 5 · Answer 1 · edited Mar 16 '14 at 19:30

5

You can't run multiple statements with the mysql_* API. You either need to break them up into multiple statements or, better yet, use the mysqli_* API.

The mysql_* API is deprecated so you shouldn't be using it anyway. And with the mysqli_* API you could use mysqli_multi_query() to run multiple statements at one time.

edited Mar 16 '14 at 19:30

user2864740

60,010
15
145
220

answered Mar 16 '14 at 19:27

John Conde

217,595
99
455
496

Where are the multiple queries? – Cjmarkham Mar 16 '14 at 19:28
`USE carshop;` is one query. The insert statement is the second. – John Conde Mar 16 '14 at 19:29
Please press the "Accept" button. The "[Solved]" edit is nice, but SO actually relies on "Accept" – Smandoli Mar 16 '14 at 19:55

score 0 · Answer 2 · answered Mar 16 '14 at 19:37

I would suggest doing something like this instead (if you really need to specify the database):

function CreateUser(){
$token = md5(uniqid(rand(),true));
$query = "INSERT IGNORE INTO carshop.users VALUES(
    '',
    '$GLOBALS[nume]',
    '$GLOBALS[pren]',
    '$GLOBALS[mail]',
    '$GLOBALS[adresa]',
    '$GLOBALS[parola]',
    '$token',
    '0',
    '0',
    '');";
echo $query;
mysql_query($query)or die("Error: ".mysql_error());
break;
}

I keep getting "You have an error in your SQL syntax" and the SQL works if run directly

2 Answers2