Why won't this simple Java code not pass this test?

Question

The code seems correct and straight forward to me, I'm using the basic indexOf method for an array i created.

Why won't this code:

public int indexOf(X s)
{        
    for (int i = 0; i <= arr.length-1; i++)
    {
        if (arr[i] == s)
        {
            return i;
        } 
    }        
    return -1;
}

pass this test:

@Test
public void testIndexOf()
{
    BetterArray<String> b = new BetterArray<String>();

    for (int i = 0; i < 20; i++)
        b.add("str" + i);

    assertEquals(0, b.indexOf("str0"));
    assertEquals(19, b.indexOf("str19"));
    assertEquals(-1, b.indexOf("not found"));
}

What do you mean by "this test"? – rootmeanclaire Mar 16 '14 at 23:46 — rootmeanclaire, Mar 16 '14 at 23:46

score 1 · Answer 1 · edited May 23 '17 at 12:05

1

Cause you compare String or any other object equality with equals() not with ==.

== tests for reference equality.

.equals() tests for value equality.

Read more : How do I compare strings in Java?

edited May 23 '17 at 12:05

Community

1
1

answered Mar 16 '14 at 23:45

nachokk

14,363
4
24
53

so that helped, but the last test failed, the one where it should return -1. – Jakkie Chan Mar 17 '14 at 00:19

Why won't this simple Java code not pass this test?

1 Answers1