2

I have a model that's using activerecord lifecycle callbacks pretty heavily. I'm using the after_commit callback to execute sidekiq jobs that require a primary key to run, on create.

after_commit on: :create do
  async_process
end

The code inside the block is never run.

However, when I do 

after_commit :on => :create do
  async_process
end

The code runs fine.

As I understand it, these two different lines should be interpreted exactly the same way. What am I missing?

I'm using ruby 2.0.0p247, Rails 3.2.17.

dfried
  • 23
  • 3
  • Are you sure you're using `on: :create` rather than `on: create`? – mu is too short Mar 24 '14 at 20:06
  • Looks like it should run fine. Also, you dont need the do block. you could write it after_commit :async_process, on: :create – emcanes Mar 24 '14 at 20:09
  • @muistooshort yeah, but good guess. emcanes it works with colon syntax without a do block, and with hashrocket syntax with a do block. – dfried Mar 25 '14 at 15:52

2 Answers2

0

It works for me using same Ruby and Rails versions. Alternatively, you can try with another accepted syntax:

after_commit :async_process, on: :create
markets
  • 6,709
  • 1
  • 38
  • 48
0

I've found using the aliases (rather than :on solved this issue for me:

after_create_commit { CreateS3BucketWorker.perform_async(id) }

All of my logic is already extracted to a sidekiq worker so creating a named function just to call the worker seemed excessive. Passing in a block let's me call the worker and keep my callback to 1 line.

user341493
  • 414
  • 1
  • 7
  • 15