ActionListener not doing anything

Question

I am new to Java, so please bear with me. I've tried to get a button to open up a new frame called AboutFrame, but whenever I press the button nothing happens.

I implement the ActionListener first:

class MainFrame extends JFrame implements ActionListener {

Then I set the button (after the usual super("blabla");...)

JButton info = new JButton("About Failsafe");
    info.addActionListener(this);

And then:

public void actionPerformed(ActionEvent event) {
String command = event.getSource().toString();
    if (command == "info") {
        AboutFrame abt = new AboutFrame();
    }
}

So what am I doing wrong here? I can't see any mistakes..

Your condition will never be evaluated to true even if you use equals. Did you try to print what `event.getSource().toString();` returns? Just use `if(info == event.getSource())` — Alexis C., Mar 25 '14 at 20:00

splungebob · Accepted Answer · 2014-03-25T20:16:35.180

2

You're not getting the command text correctly:

JButton button = (JButton) event.getSource();
String command = button.getText();

if (command.equals("About Failsafe"))
{
  AboutFrame abt = new AboutFrame();
  abt.setVisible(true);
}

Or, if your JButton info; declaration is an instance variable (instead of a local one), you could make your if-check:

if (event.getSource() == info)

edited Mar 25 '14 at 20:16

answered Mar 25 '14 at 20:11

splungebob

5,357
2
22
45

The first solution worked! Thanks so much :) – TheGie Mar 25 '14 at 20:23

zomnombom · Answer 2 · 2014-03-25T20:16:28.673

0

Try:

if (event.getSource()==info) {}

instead of if (command=="info") {}.

edited Mar 25 '14 at 20:16

answered Mar 25 '14 at 20:07

zomnombom

986
2
9
15

`if (command.equals("info"))` How will this work? "info" is the variable name, not the command text of the JButton. – splungebob Mar 25 '14 at 20:13
You are right. My mistake. I'm sorry. – zomnombom Mar 25 '14 at 20:15

ActionListener not doing anything

2 Answers2

Linked