Notice: Undefined index body

Question

I have sth like this:

<?php
    $body = $_GET["body"];
    if ($body=="")
    {
        include("includes/desktop.php");
    }
    else
    {
        if (is_file("includes/$body.php"))
        {
            include("includes/$body.php");
        }   
        else
        {
            include("includes/desktop.php");
        }        
    }                              
?>

How to make that this notice will disappear? It happens only when $_GET["body"] is empty.

Notice: Undefined index: body in C:\wamp\www\admin\index.php on line 106

possible duplicate of [PHP: "Notice: Undefined variable" and "Notice: Undefined index"](http://stackoverflow.com/questions/4261133/php-notice-undefined-variable-and-notice-undefined-index) — George, Mar 27 '14 at 10:45

score 1 · Accepted Answer · edited May 23 '17 at 12:05

1

change

$body = $_GET["body"];

To

$body = isset($_GET["body"]) ? $_GET["body"] : '';

You can find almost all symbols and operators in php here

edited May 23 '17 at 12:05

Community

1
1

answered Mar 27 '14 at 10:45

Nauphal

6,194
4
27
43

It works for me. But truth telling I've never seen sth like this. Could you tell me what exactly mean "?" and ':' ? – Mar 27 '14 at 10:50
@user3261158: Ternary operator – Nauphal Mar 27 '14 at 10:52
Ok. Thank's for help. – Mar 27 '14 at 10:55
1

@user3261158: I have updated the answer with SO link. It is really helpful. – Nauphal Mar 27 '14 at 10:56

dkasipovic · Answer 2 · 2014-03-27T11:00:58.217

0

It is warning you that body is not sent via $_GET. You need to do something like this

<?php
    if (isset($_GET["body"])) {
      $body = $_GET["body"];
      if ($body=="")
      {
          include("includes/desktop.php");
      }
      else
      {
          if (is_file("includes/$body.php"))
          {
              include("includes/$body.php");
          }   
          else
          {
              include("includes/desktop.php");
          }        
      }                              
  }
?>

edited Mar 27 '14 at 11:00

answered Mar 27 '14 at 10:45

dkasipovic

5,930
1
19
25

There should be also ')' in second line. But It doesn't work. – Mar 27 '14 at 10:52

score 0 · Answer 3 · answered Mar 27 '14 at 10:46

It's happening because there is no index body in the superglobal $_GET array. In other words, you're not passing $_GET['body'].

Instead use:

if (isset($_GET['body']) && $_GET['body']) {

That checks for both the index and a meaningful (non-falsy) value.

score 0 · Answer 4 · answered Mar 27 '14 at 10:48

Try

if (!isset($_GET['body']) || empty($_GET['body'])) {
   include("includes/desktop.php");
} else {
    ...
}

http://www.php.net/isset

On a side note: You should never trust user input. Directly passing the body GET parameter to your include() call allows a malicious user to include files you never intended to load.

Notice: Undefined index body

4 Answers4