More elegant way of (un)checking in jQuery?

Question

I tried to entirely script this checkbox check / uncheck snippet of code in jQuery, but it did not have any success. Here is the jQuery/JavaScript code:

$.ajax({
                type: "GET",
                url: "check.xml",
                cache: false,
                dataType: "xml",
                success: function(xml) {
                    $(xml).find("check").each(function(){
                        $(xml).find("todo").each(function(){
                            var state = $(this).attr("state");
                            if (state == "true") {
                                document.getElementById($(this).attr("id")).checked = true;
                            } else {
                                document.getElementById($(this).attr("id")).checked = false;
                            }
                        });
                    });
                }
            });

It's probably very possible to do the document.getElementbyId(blablabla).... using only jQuery. I tried this:

($(this).attr("id")).prop("checked", true)

But that didn't really work as expected. Any suggestions?

http://stackoverflow.com/questions/426258/how-do-i-check-a-checkbox-with-jquery — MSadura, Mar 28 '14 at 13:29

score 1 · Answer 1 · edited Mar 28 '14 at 13:36

1

You need to do it like this (note the # symbol to get a element from the ID - same rules than CSS selectors) -

var id = $(this).attr("id");
$('#'+ id).prop("checked", true);

edited Mar 28 '14 at 13:36

Paul Rad

4,820
1
22
23

answered Mar 28 '14 at 13:29

Adil Shaikh

44,509
17
89
111

1

Isn't that just `$(this).prop('checked',true)` ? – dkasipovic Mar 28 '14 at 13:35
2

@D.Kasipovic No, Op is traversing over xml, not on actual DOM elements – Adil Shaikh Mar 28 '14 at 13:37

score 0 · Accepted Answer · answered Mar 28 '14 at 13:39

0

You're missing the "#" in the selector:

var id = '#'+ $(this).attr("id");

Then you can do a one liner instead of the "if":

$(id).prop("checked", (state == "true"));

answered Mar 28 '14 at 13:39

Wilmer

2,511
1
14
8

That is what I mean elegance. Thank you. – maikovich Mar 28 '14 at 13:48

More elegant way of (un)checking in jQuery?

2 Answers2