How to read the first line of a text file in java and print it out?

Question

I want to save a state by write into a file and then read the file later with bufferedReader to get the state again. Here is my code:

public static void main(String[] args) throws IOException{

   FileWriter fw = new FileWriter("C:\\Users\\Nicolas\\Desktop\\save.txt");
   BufferedWriter save = new BufferedWriter(fw);

   save.write("helloWorld");

   BufferedReader r = new BufferedReader(new FileReader("C:\\Users\\Nicolas\\Desktop\\save.txt"));

   System.out.println(r.readLine());

   save.close();        
}

If I press run, I got printed out null. I tried it with:

if(r.readLine() != null){
    System.out.println(r.readLine());
}

But logically it prints me out nothing now. I don't know what I am doing wrong here. Can you help me please?

r.close() you should also need to close the BufferedReader as well — Tech Nerd, Mar 29 '14 at 09:05
possible duplicate of [file writer doesn't work](http://stackoverflow.com/questions/11888496/file-writer-doesnt-work) — Raedwald, Mar 29 '14 at 11:40

jpw · Answer 1 · 2014-03-29T09:08:46.520

0

A BufferedWriter buffers output until you flush the stream you write to so you need to flush the stream by either closing the file or using save.flush().

 public static void main(String[] args) throws IOException {

        FileWriter fw = new FileWriter("C:\\Users\\Nicolas\\Desktop\\save.txt");
        BufferedWriter save = new BufferedWriter(fw);

        save.write("helloWorld");
        save.flush();  // this writes the bytes in the stream to the file.

        BufferedReader r = new BufferedReader(new FileReader("C:\\Users\\Nicolas\\Desktop\\save.txt"));

        System.out.println(r.readLine());

        save.close();
    }

edited Mar 29 '14 at 09:08

answered Mar 29 '14 at 09:01

jpw

44,361
6
66
86

I think BufferedReader should also need to be closed after reading using r.close(); – Tech Nerd Mar 29 '14 at 09:06
@JunaidHassan It should yes, and also exceptions should be handled, but that's another issue. This gets it working but isn't perfect. – jpw Mar 29 '14 at 09:07
Yes you get the point and yes exceptions should also be caught – Tech Nerd Mar 29 '14 at 09:08

score 0 · Answer 2 · answered Mar 29 '14 at 09:08

  // Write to file      
  FileWriter fw = new FileWriter("C:\\Users\\Nicolas\\Desktop\\save.txt");
  BufferedWriter save = new BufferedWriter(fw);

  save.write("example");
  save.flush()

  // read as stream
  BufferedReader r = new BufferedReader(new FileReader("C:\\Users\\Nicolas\\Desktop\\save.txt"));
  System.out.println(r.readLine());

  save.close();

score 0 · Accepted Answer · answered Mar 29 '14 at 09:35

When writing to a file with a BufferedWriter, the content is not directly written to disk, as it is obviously buffered. You should flush the content as @ludo_rj suggested in his answer.

Better yet is to close the writer as early as possible, which will automatically flush the content. Closing the reader is also necessary, by the way.

You should go with the following mechanism (I have distributed the approach into several methods to make it more clear):

public class SaveStateTesing {

    private static final String FILE_NAME = "C:\\Users\\Nicolas\\Desktop\\save.txt";

    public static void main(String[] args) throws IOException {
        saveState("helloWorld", FILE_NAME);
        String state = readState(FILE_NAME);
        System.out.println(state);
    }

    private static void saveState(String state, String fileName) throws IOException {
        try(PrintWriter writer = new PrintWriter(new BufferedWriter(new FileWriter(fileName)))) {
            writer.println(state);
        }
    }

    private static String readState(String fileName) throws IOException {
        try(BufferedReader reader = new BufferedReader(new FileReader(fileName))) {
            return reader.readLine();
        }
    }

}

Note, that I used the try-with-resource statement, only available in Java 7 (and 8, of course). If you are running it in an older Java version, you must write the methods as following:

    private static void saveState(String state, String fileName) throws IOException {
        PrintWriter writer = null;
        try {
            writer = new PrintWriter(new BufferedWriter(new FileWriter(fileName)));
            writer.println(state);
        } finally {
            if (writer != null)
                writer.close();
        }
    }

    private static String readState(String fileName) throws IOException {
        BufferedReader reader = null;
        try {
            reader = new BufferedReader(new FileReader(fileName));
            return reader.readLine();
        } finally {
            if (reader != null)
                reader.close();
        }
    }

How to read the first line of a text file in java and print it out?

3 Answers3